Spark Launcher instrumentation: Capture time app-related metrics#10708
Spark Launcher instrumentation: Capture time app-related metrics#10708aboitreaud wants to merge 2 commits intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 64 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.054 s) : 0, 1054260
Total [baseline] (8.864 s) : 0, 8863782
Agent [candidate] (1.069 s) : 0, 1069263
Total [candidate] (8.815 s) : 0, 8814642
section iast
Agent [baseline] (1.24 s) : 0, 1239816
Total [baseline] (9.57 s) : 0, 9569851
Agent [candidate] (1.226 s) : 0, 1225846
Total [candidate] (9.546 s) : 0, 9546212
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.21 ms) : 0, 1210
BytebuddyAgent [baseline] (626.988 ms) : 0, 626988
BytebuddyAgent [candidate] (637.028 ms) : 0, 637028
AgentMeter [baseline] (29.154 ms) : 0, 29154
AgentMeter [candidate] (29.645 ms) : 0, 29645
GlobalTracer [baseline] (256.807 ms) : 0, 256807
GlobalTracer [candidate] (259.234 ms) : 0, 259234
AppSec [baseline] (31.454 ms) : 0, 31454
AppSec [candidate] (31.928 ms) : 0, 31928
Debugger [baseline] (58.623 ms) : 0, 58623
Debugger [candidate] (59.535 ms) : 0, 59535
Remote Config [baseline] (599.977 µs) : 0, 600
Remote Config [candidate] (592.355 µs) : 0, 592
Telemetry [baseline] (8.66 ms) : 0, 8660
Telemetry [candidate] (8.831 ms) : 0, 8831
Flare Poller [baseline] (4.925 ms) : 0, 4925
Flare Poller [candidate] (5.07 ms) : 0, 5070
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (807.995 ms) : 0, 807995
BytebuddyAgent [candidate] (796.44 ms) : 0, 796440
AgentMeter [baseline] (11.74 ms) : 0, 11740
AgentMeter [candidate] (11.342 ms) : 0, 11342
GlobalTracer [baseline] (248.119 ms) : 0, 248119
GlobalTracer [candidate] (246.926 ms) : 0, 246926
AppSec [baseline] (26.497 ms) : 0, 26497
AppSec [candidate] (26.346 ms) : 0, 26346
Debugger [baseline] (62.534 ms) : 0, 62534
Debugger [candidate] (62.21 ms) : 0, 62210
Remote Config [baseline] (524.273 µs) : 0, 524
Remote Config [candidate] (517.161 µs) : 0, 517
Telemetry [baseline] (14.769 ms) : 0, 14769
Telemetry [candidate] (14.782 ms) : 0, 14782
Flare Poller [baseline] (4.893 ms) : 0, 4893
Flare Poller [candidate] (4.892 ms) : 0, 4892
IAST [baseline] (25.375 ms) : 0, 25375
IAST [candidate] (25.17 ms) : 0, 25170
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055642
Total [baseline] (10.981 s) : 0, 10981443
Agent [candidate] (1.057 s) : 0, 1056679
Total [candidate] (11.081 s) : 0, 11080653
section appsec
Agent [baseline] (1.253 s) : 0, 1253004
Total [baseline] (11.105 s) : 0, 11104904
Agent [candidate] (1.245 s) : 0, 1245403
Total [candidate] (11.168 s) : 0, 11168136
section iast
Agent [baseline] (1.229 s) : 0, 1229095
Total [baseline] (11.384 s) : 0, 11384404
Agent [candidate] (1.234 s) : 0, 1234431
Total [candidate] (11.286 s) : 0, 11285640
section profiling
Agent [baseline] (1.182 s) : 0, 1182449
Total [baseline] (10.977 s) : 0, 10977009
Agent [candidate] (1.19 s) : 0, 1190273
Total [candidate] (11.017 s) : 0, 11017149
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.182 ms) : 0, 1182
crashtracking [candidate] (1.189 ms) : 0, 1189
BytebuddyAgent [baseline] (626.455 ms) : 0, 626455
BytebuddyAgent [candidate] (627.294 ms) : 0, 627294
AgentMeter [baseline] (28.966 ms) : 0, 28966
AgentMeter [candidate] (29.267 ms) : 0, 29267
GlobalTracer [baseline] (256.008 ms) : 0, 256008
GlobalTracer [candidate] (257.333 ms) : 0, 257333
AppSec [baseline] (31.391 ms) : 0, 31391
AppSec [candidate] (31.753 ms) : 0, 31753
Debugger [baseline] (59.27 ms) : 0, 59270
Debugger [candidate] (59.713 ms) : 0, 59713
Remote Config [baseline] (591.794 µs) : 0, 592
Remote Config [candidate] (592.044 µs) : 0, 592
Telemetry [baseline] (8.647 ms) : 0, 8647
Telemetry [candidate] (8.661 ms) : 0, 8661
Flare Poller [baseline] (7.237 ms) : 0, 7237
Flare Poller [candidate] (4.997 ms) : 0, 4997
section appsec
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (662.836 ms) : 0, 662836
BytebuddyAgent [candidate] (657.839 ms) : 0, 657839
AgentMeter [baseline] (12.007 ms) : 0, 12007
AgentMeter [candidate] (11.993 ms) : 0, 11993
GlobalTracer [baseline] (259.509 ms) : 0, 259509
GlobalTracer [candidate] (258.123 ms) : 0, 258123
IAST [baseline] (24.215 ms) : 0, 24215
IAST [candidate] (23.904 ms) : 0, 23904
AppSec [baseline] (178.158 ms) : 0, 178158
AppSec [candidate] (177.104 ms) : 0, 177104
Debugger [baseline] (65.624 ms) : 0, 65624
Debugger [candidate] (65.722 ms) : 0, 65722
Remote Config [baseline] (562.351 µs) : 0, 562
Remote Config [candidate] (580.892 µs) : 0, 581
Telemetry [baseline] (9.035 ms) : 0, 9035
Telemetry [candidate] (9.125 ms) : 0, 9125
Flare Poller [baseline] (3.586 ms) : 0, 3586
Flare Poller [candidate] (3.621 ms) : 0, 3621
section iast
crashtracking [baseline] (1.185 ms) : 0, 1185
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (796.672 ms) : 0, 796672
BytebuddyAgent [candidate] (801.098 ms) : 0, 801098
AgentMeter [baseline] (11.37 ms) : 0, 11370
AgentMeter [candidate] (11.545 ms) : 0, 11545
GlobalTracer [baseline] (248.4 ms) : 0, 248400
GlobalTracer [candidate] (248.251 ms) : 0, 248251
IAST [baseline] (25.289 ms) : 0, 25289
IAST [candidate] (25.367 ms) : 0, 25367
AppSec [baseline] (26.538 ms) : 0, 26538
AppSec [candidate] (26.506 ms) : 0, 26506
Debugger [baseline] (63.407 ms) : 0, 63407
Debugger [candidate] (63.897 ms) : 0, 63897
Remote Config [baseline] (521.654 µs) : 0, 522
Remote Config [candidate] (523.058 µs) : 0, 523
Telemetry [baseline] (14.96 ms) : 0, 14960
Telemetry [candidate] (14.979 ms) : 0, 14979
Flare Poller [baseline] (4.858 ms) : 0, 4858
Flare Poller [candidate] (4.977 ms) : 0, 4977
section profiling
crashtracking [baseline] (1.174 ms) : 0, 1174
crashtracking [candidate] (1.163 ms) : 0, 1163
BytebuddyAgent [baseline] (682.255 ms) : 0, 682255
BytebuddyAgent [candidate] (689.546 ms) : 0, 689546
AgentMeter [baseline] (8.539 ms) : 0, 8539
AgentMeter [candidate] (8.612 ms) : 0, 8612
GlobalTracer [baseline] (215.421 ms) : 0, 215421
GlobalTracer [candidate] (216.151 ms) : 0, 216151
AppSec [baseline] (32.037 ms) : 0, 32037
AppSec [candidate] (32.177 ms) : 0, 32177
Debugger [baseline] (62.499 ms) : 0, 62499
Debugger [candidate] (61.524 ms) : 0, 61524
Remote Config [baseline] (586.834 µs) : 0, 587
Remote Config [candidate] (589.317 µs) : 0, 589
Telemetry [baseline] (11.298 ms) : 0, 11298
Telemetry [candidate] (11.291 ms) : 0, 11291
Flare Poller [baseline] (3.539 ms) : 0, 3539
Flare Poller [candidate] (4.285 ms) : 0, 4285
ProfilingAgent [baseline] (94.426 ms) : 0, 94426
ProfilingAgent [candidate] (94.117 ms) : 0, 94117
Profiling [baseline] (94.996 ms) : 0, 94996
Profiling [candidate] (94.683 ms) : 0, 94683
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1181, 1204
. : milestone, 1192,
iast (3.089 ms) : 3049, 3128
. : milestone, 3089,
iast_FULL (6.026 ms) : 5965, 6088
. : milestone, 6026,
iast_GLOBAL (3.681 ms) : 3618, 3745
. : milestone, 3681,
profiling (1.943 ms) : 1926, 1960
. : milestone, 1943,
tracing (1.837 ms) : 1822, 1852
. : milestone, 1837,
section candidate
no_agent (1.188 ms) : 1176, 1200
. : milestone, 1188,
iast (3.146 ms) : 3106, 3185
. : milestone, 3146,
iast_FULL (6.113 ms) : 6050, 6176
. : milestone, 6113,
iast_GLOBAL (3.5 ms) : 3444, 3557
. : milestone, 3500,
profiling (2.022 ms) : 2004, 2040
. : milestone, 2022,
tracing (1.752 ms) : 1738, 1765
. : milestone, 1752,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section baseline
no_agent (17.99 ms) : 17808, 18173
. : milestone, 17990,
appsec (18.651 ms) : 18463, 18838
. : milestone, 18651,
code_origins (17.565 ms) : 17394, 17736
. : milestone, 17565,
iast (18.667 ms) : 18479, 18854
. : milestone, 18667,
profiling (18.706 ms) : 18524, 18887
. : milestone, 18706,
tracing (18.08 ms) : 17902, 18258
. : milestone, 18080,
section candidate
no_agent (18.785 ms) : 18595, 18975
. : milestone, 18785,
appsec (18.566 ms) : 18379, 18752
. : milestone, 18566,
code_origins (17.705 ms) : 17530, 17879
. : milestone, 17705,
iast (18.827 ms) : 18637, 19017
. : milestone, 18827,
profiling (18.93 ms) : 18745, 19115
. : milestone, 18930,
tracing (17.626 ms) : 17454, 17798
. : milestone, 17626,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section baseline
no_agent (1.484 ms) : 1472, 1495
. : milestone, 1484,
appsec (3.747 ms) : 3530, 3963
. : milestone, 3747,
iast (2.254 ms) : 2185, 2323
. : milestone, 2254,
iast_GLOBAL (2.303 ms) : 2233, 2372
. : milestone, 2303,
profiling (2.088 ms) : 2034, 2143
. : milestone, 2088,
tracing (2.072 ms) : 2018, 2125
. : milestone, 2072,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (2.525 ms) : 2470, 2580
. : milestone, 2525,
iast (2.263 ms) : 2194, 2332
. : milestone, 2263,
iast_GLOBAL (2.305 ms) : 2236, 2374
. : milestone, 2305,
profiling (2.086 ms) : 2031, 2141
. : milestone, 2086,
tracing (2.071 ms) : 2017, 2124
. : milestone, 2071,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~891d0dfb55, baseline=1.61.0-SNAPSHOT~9b93366972
dateFormat X
axisFormat %s
section baseline
no_agent (15.524 s) : 15524000, 15524000
. : milestone, 15524000,
appsec (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
iast (17.988 s) : 17988000, 17988000
. : milestone, 17988000,
iast_GLOBAL (17.693 s) : 17693000, 17693000
. : milestone, 17693000,
profiling (15.601 s) : 15601000, 15601000
. : milestone, 15601000,
tracing (15.034 s) : 15034000, 15034000
. : milestone, 15034000,
section candidate
no_agent (15.312 s) : 15312000, 15312000
. : milestone, 15312000,
appsec (14.842 s) : 14842000, 14842000
. : milestone, 14842000,
iast (18.338 s) : 18338000, 18338000
. : milestone, 18338000,
iast_GLOBAL (17.815 s) : 17815000, 17815000
. : milestone, 17815000,
profiling (14.79 s) : 14790000, 14790000
. : milestone, 14790000,
tracing (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
|
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 100126315 took longer than expected. The current limit for the base branch 'master' is 120 minutes. |
Motivation
We recently added instrumentation for the spark launcher class, but without any spark metric. As we collect a lot of Spark metrics for Spark application spans, we'd like to get some for launchers too. Issue is that there is no point in collecting the same metrics for the launcher VM as the launcher is a thin wrapper around spark applications.
The goal of this PR is to enrich the spark.launcher.launch spans with with metrics that make sense in the context of a launcher.
Changes
Collect 3 new metrics to measure the spark launcher to app latency:
Values are computed by storing the start time and measuring the lag between start time and events related to each metric.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.