Skip to content

Spark Launcher instrumentation: Capture time app-related metrics #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 2 commits into from
Mar 3, 2026
Merged

Spark Launcher instrumentation: Capture time app-related metrics #10708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cbda77
capture latency metrics
aboitreaud Mar 1, 2026
891d0df
Merge branch 'master' into adrien.boitreaud/spark-launcher-metrics
aboitreaud Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions ...spark-common/src/main/java/datadog/trace/instrumentation/spark/SparkLauncherListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ public class SparkLauncherListener implements SparkAppHandle.Listener {

private static volatile boolean shutdownHookRegistered = false;

private static long spanStartTimeMs = 0L;
private static long connectedTimeMs = 0L;
private static long submittedTimeMs = 0L;
private static long runningTimeMs = 0L;

public static synchronized void createLauncherSpan(Object launcher) {
if (launcherSpan != null) {
return;
Expand All @@ -40,6 +45,10 @@ public static synchronized void createLauncherSpan(Object launcher) {
span.setSamplingPriority(PrioritySampling.USER_KEEP, SamplingMechanism.DATA_JOBS);
setLauncherConfigTags(span, launcher);
captureEmrStepId(span);
spanStartTimeMs = System.currentTimeMillis();
connectedTimeMs = 0L;
submittedTimeMs = 0L;
runningTimeMs = 0L;
launcherSpan = span;

if (!shutdownHookRegistered) {
Expand All @@ -52,6 +61,7 @@ public static synchronized void createLauncherSpan(Object launcher) {
AgentSpan s = launcherSpan;
if (s != null) {
log.info("Finishing spark.launcher span from shutdown hook");
setTimingMetrics(s);
s.finish();
launcherSpan = null;
}
Expand All @@ -70,6 +80,7 @@ public static synchronized void finishSpan(boolean isError, String errorMessage)
span.setTag(DDTags.ERROR_TYPE, "Spark Launcher Failed");
span.setTag(DDTags.ERROR_MSG, errorMessage);
}
setTimingMetrics(span);
span.finish();
launcherSpan = null;
}
Expand All @@ -82,17 +93,34 @@ public static synchronized void finishSpanWithThrowable(Throwable throwable) {
if (throwable != null) {
span.addThrowable(throwable);
}
setTimingMetrics(span);
span.finish();
launcherSpan = null;
}

private static void setTimingMetrics(AgentSpan span) {
if (spanStartTimeMs <= 0L) {
return;
}
if (connectedTimeMs > 0L) {
span.setMetric("spark.launcher.time_to_connected_ms", connectedTimeMs - spanStartTimeMs);
}
if (submittedTimeMs > 0L) {
span.setMetric("spark.launcher.time_to_submitted_ms", submittedTimeMs - spanStartTimeMs);
}
if (runningTimeMs > 0L) {
span.setMetric("spark.launcher.time_to_running_ms", runningTimeMs - spanStartTimeMs);
}
}

@Override
public void stateChanged(SparkAppHandle handle) {
synchronized (SparkLauncherListener.class) {
SparkAppHandle.State state = handle.getState();
AgentSpan span = launcherSpan;
if (span != null) {
span.setTag("spark.launcher.app_state", state.toString());
recordStateTimestamp(state);

String appId = handle.getAppId();
if (appId != null) {
Expand Down Expand Up @@ -132,6 +160,23 @@ public void infoChanged(SparkAppHandle handle) {
}
}

private static void recordStateTimestamp(SparkAppHandle.State state) {
long now = System.currentTimeMillis();
if (state == SparkAppHandle.State.CONNECTED) {
if (connectedTimeMs == 0L) {
connectedTimeMs = now;
}
} else if (state == SparkAppHandle.State.SUBMITTED) {
if (submittedTimeMs == 0L) {
submittedTimeMs = now;
}
} else if (state == SparkAppHandle.State.RUNNING) {
if (runningTimeMs == 0L) {
runningTimeMs = now;
}
}
}

private static void captureEmrStepId(AgentSpan span) {
String stepId = EmrUtils.getEmrStepId();
if (stepId != null) {
Expand Down