Add workflow to prevent new Groovy test files#10730
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom Mar 4, 2026
Merged
Add workflow to prevent new Groovy test files#10730gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits intomasterfrom
Conversation
sarahchen6
force-pushed
the
sarahchen6/workflow-to-enforce-no-groovy
branch
from
b77de38 to
8164b95
Compare
sarahchen6
added
tag: no release notes
sarahchen6
added
tag: override-groovy-enforcement
Contributor
Author
|
We can confirm that adding the |
sarahchen6
added
the
tag: override-groovy-enforcement
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.055 s) : 0, 1055121
Total [baseline] (8.836 s) : 0, 8835813
Agent [candidate] (1.058 s) : 0, 1058380
Total [candidate] (8.807 s) : 0, 8806730
section iast
Agent [baseline] (1.224 s) : 0, 1223539
Total [baseline] (9.551 s) : 0, 9551443
Agent [candidate] (1.235 s) : 0, 1234627
Total [candidate] (9.55 s) : 0, 9549582
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.209 ms) : 0, 1209
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (628.056 ms) : 0, 628056
BytebuddyAgent [candidate] (628.74 ms) : 0, 628740
AgentMeter [baseline] (28.975 ms) : 0, 28975
AgentMeter [candidate] (29.157 ms) : 0, 29157
GlobalTracer [baseline] (256.144 ms) : 0, 256144
GlobalTracer [candidate] (256.762 ms) : 0, 256762
AppSec [baseline] (31.476 ms) : 0, 31476
AppSec [candidate] (31.453 ms) : 0, 31453
Debugger [baseline] (58.353 ms) : 0, 58353
Debugger [candidate] (58.589 ms) : 0, 58589
Remote Config [baseline] (585.22 µs) : 0, 585
Remote Config [candidate] (585.349 µs) : 0, 585
Telemetry [baseline] (8.589 ms) : 0, 8589
Telemetry [candidate] (8.711 ms) : 0, 8711
Flare Poller [baseline] (5.689 ms) : 0, 5689
Flare Poller [candidate] (7.208 ms) : 0, 7208
section iast
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (794.879 ms) : 0, 794879
BytebuddyAgent [candidate] (802.637 ms) : 0, 802637
AgentMeter [baseline] (11.269 ms) : 0, 11269
AgentMeter [candidate] (11.594 ms) : 0, 11594
GlobalTracer [baseline] (246.163 ms) : 0, 246163
GlobalTracer [candidate] (248.345 ms) : 0, 248345
AppSec [baseline] (26.22 ms) : 0, 26220
AppSec [candidate] (27.323 ms) : 0, 27323
Debugger [baseline] (62.386 ms) : 0, 62386
Debugger [candidate] (61.744 ms) : 0, 61744
Remote Config [baseline] (528.508 µs) : 0, 529
Remote Config [candidate] (526.354 µs) : 0, 526
Telemetry [baseline] (14.837 ms) : 0, 14837
Telemetry [candidate] (14.832 ms) : 0, 14832
Flare Poller [baseline] (4.952 ms) : 0, 4952
Flare Poller [candidate] (4.886 ms) : 0, 4886
IAST [baseline] (25.091 ms) : 0, 25091
IAST [candidate] (25.361 ms) : 0, 25361
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055543
Total [baseline] (10.948 s) : 0, 10947951
Agent [candidate] (1.056 s) : 0, 1056496
Total [candidate] (10.983 s) : 0, 10982915
section appsec
Agent [baseline] (1.244 s) : 0, 1243620
Total [baseline] (11.101 s) : 0, 11101438
Agent [candidate] (1.242 s) : 0, 1241663
Total [candidate] (11.206 s) : 0, 11205537
section iast
Agent [baseline] (1.226 s) : 0, 1226270
Total [baseline] (11.3 s) : 0, 11299735
Agent [candidate] (1.225 s) : 0, 1225249
Total [candidate] (11.359 s) : 0, 11358959
section profiling
Agent [baseline] (1.195 s) : 0, 1195260
Total [baseline] (11.139 s) : 0, 11138908
Agent [candidate] (1.181 s) : 0, 1180802
Total [candidate] (10.908 s) : 0, 10907552
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.192 ms) : 0, 1192
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (626.583 ms) : 0, 626583
BytebuddyAgent [candidate] (627.134 ms) : 0, 627134
AgentMeter [baseline] (29.012 ms) : 0, 29012
AgentMeter [candidate] (29.064 ms) : 0, 29064
GlobalTracer [baseline] (255.851 ms) : 0, 255851
GlobalTracer [candidate] (255.527 ms) : 0, 255527
AppSec [baseline] (31.366 ms) : 0, 31366
AppSec [candidate] (31.301 ms) : 0, 31301
Debugger [baseline] (59.087 ms) : 0, 59087
Debugger [candidate] (59.046 ms) : 0, 59046
Remote Config [baseline] (579.32 µs) : 0, 579
Remote Config [candidate] (595.103 µs) : 0, 595
Telemetry [baseline] (8.565 ms) : 0, 8565
Telemetry [candidate] (8.628 ms) : 0, 8628
Flare Poller [baseline] (7.312 ms) : 0, 7312
Flare Poller [candidate] (8.168 ms) : 0, 8168
section appsec
crashtracking [baseline] (1.2 ms) : 0, 1200
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (657.232 ms) : 0, 657232
BytebuddyAgent [candidate] (656.213 ms) : 0, 656213
AgentMeter [baseline] (11.977 ms) : 0, 11977
AgentMeter [candidate] (11.914 ms) : 0, 11914
GlobalTracer [baseline] (257.778 ms) : 0, 257778
GlobalTracer [candidate] (257.018 ms) : 0, 257018
AppSec [baseline] (176.823 ms) : 0, 176823
AppSec [candidate] (176.937 ms) : 0, 176937
Debugger [baseline] (65.477 ms) : 0, 65477
Debugger [candidate] (65.237 ms) : 0, 65237
Remote Config [baseline] (564.864 µs) : 0, 565
Remote Config [candidate] (574.846 µs) : 0, 575
Telemetry [baseline] (8.925 ms) : 0, 8925
Telemetry [candidate] (9.05 ms) : 0, 9050
Flare Poller [baseline] (3.577 ms) : 0, 3577
Flare Poller [candidate] (3.568 ms) : 0, 3568
IAST [baseline] (23.864 ms) : 0, 23864
IAST [candidate] (23.89 ms) : 0, 23890
section iast
crashtracking [baseline] (1.194 ms) : 0, 1194
crashtracking [candidate] (1.185 ms) : 0, 1185
BytebuddyAgent [baseline] (795.722 ms) : 0, 795722
BytebuddyAgent [candidate] (794.549 ms) : 0, 794549
AgentMeter [baseline] (11.32 ms) : 0, 11320
AgentMeter [candidate] (11.284 ms) : 0, 11284
GlobalTracer [baseline] (247.007 ms) : 0, 247007
GlobalTracer [candidate] (247.095 ms) : 0, 247095
AppSec [baseline] (26.422 ms) : 0, 26422
AppSec [candidate] (26.271 ms) : 0, 26271
Debugger [baseline] (63.227 ms) : 0, 63227
Debugger [candidate] (63.419 ms) : 0, 63419
Remote Config [baseline] (528.141 µs) : 0, 528
Remote Config [candidate] (524.184 µs) : 0, 524
Telemetry [baseline] (14.826 ms) : 0, 14826
Telemetry [candidate] (14.876 ms) : 0, 14876
Flare Poller [baseline] (4.867 ms) : 0, 4867
Flare Poller [candidate] (5.027 ms) : 0, 5027
IAST [baseline] (25.189 ms) : 0, 25189
IAST [candidate] (25.111 ms) : 0, 25111
section profiling
crashtracking [baseline] (1.179 ms) : 0, 1179
crashtracking [candidate] (1.165 ms) : 0, 1165
BytebuddyAgent [baseline] (691.64 ms) : 0, 691640
BytebuddyAgent [candidate] (682.153 ms) : 0, 682153
AgentMeter [baseline] (8.675 ms) : 0, 8675
AgentMeter [candidate] (8.574 ms) : 0, 8574
GlobalTracer [baseline] (217.781 ms) : 0, 217781
GlobalTracer [candidate] (215.172 ms) : 0, 215172
AppSec [baseline] (32.289 ms) : 0, 32289
AppSec [candidate] (31.918 ms) : 0, 31918
Debugger [baseline] (65.03 ms) : 0, 65030
Debugger [candidate] (61.811 ms) : 0, 61811
Remote Config [baseline] (574.571 µs) : 0, 575
Remote Config [candidate] (576.725 µs) : 0, 577
Telemetry [baseline] (9.06 ms) : 0, 9060
Telemetry [candidate] (10.468 ms) : 0, 10468
Flare Poller [baseline] (3.492 ms) : 0, 3492
Flare Poller [candidate] (4.324 ms) : 0, 4324
ProfilingAgent [baseline] (94.095 ms) : 0, 94095
ProfilingAgent [candidate] (93.849 ms) : 0, 93849
Profiling [baseline] (94.664 ms) : 0, 94664
Profiling [candidate] (94.418 ms) : 0, 94418
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section baseline
no_agent (19.169 ms) : 18974, 19365
. : milestone, 19169,
appsec (18.673 ms) : 18489, 18858
. : milestone, 18673,
code_origins (17.467 ms) : 17296, 17639
. : milestone, 17467,
iast (17.662 ms) : 17490, 17833
. : milestone, 17662,
profiling (18.682 ms) : 18489, 18875
. : milestone, 18682,
tracing (17.724 ms) : 17548, 17900
. : milestone, 17724,
section candidate
no_agent (17.367 ms) : 17192, 17541
. : milestone, 17367,
appsec (18.942 ms) : 18749, 19136
. : milestone, 18942,
code_origins (17.641 ms) : 17468, 17815
. : milestone, 17641,
iast (18.917 ms) : 18722, 19111
. : milestone, 18917,
profiling (19.148 ms) : 18958, 19339
. : milestone, 19148,
tracing (17.905 ms) : 17728, 18082
. : milestone, 17905,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section baseline
no_agent (1.193 ms) : 1181, 1204
. : milestone, 1193,
iast (3.242 ms) : 3193, 3290
. : milestone, 3242,
iast_FULL (5.759 ms) : 5701, 5816
. : milestone, 5759,
iast_GLOBAL (3.429 ms) : 3377, 3481
. : milestone, 3429,
profiling (2.116 ms) : 2097, 2134
. : milestone, 2116,
tracing (1.806 ms) : 1791, 1821
. : milestone, 1806,
section candidate
no_agent (1.197 ms) : 1185, 1209
. : milestone, 1197,
iast (3.175 ms) : 3132, 3219
. : milestone, 3175,
iast_FULL (5.9 ms) : 5841, 5959
. : milestone, 5900,
iast_GLOBAL (3.526 ms) : 3476, 3577
. : milestone, 3526,
profiling (2.027 ms) : 2010, 2044
. : milestone, 2027,
tracing (1.793 ms) : 1778, 1809
. : milestone, 1793,
DacapoParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 0 unstable metrics.
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section baseline
no_agent (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
appsec (15.067 s) : 15067000, 15067000
. : milestone, 15067000,
iast (18.243 s) : 18243000, 18243000
. : milestone, 18243000,
iast_GLOBAL (17.712 s) : 17712000, 17712000
. : milestone, 17712000,
profiling (14.85 s) : 14850000, 14850000
. : milestone, 14850000,
tracing (15.164 s) : 15164000, 15164000
. : milestone, 15164000,
section candidate
no_agent (15.005 s) : 15005000, 15005000
. : milestone, 15005000,
appsec (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
iast (18.342 s) : 18342000, 18342000
. : milestone, 18342000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
. : milestone, 17780000,
profiling (14.977 s) : 14977000, 14977000
. : milestone, 14977000,
tracing (15.168 s) : 15168000, 15168000
. : milestone, 15168000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~70c34b64bb, baseline=1.61.0-SNAPSHOT~2f04ccb83f
dateFormat X
axisFormat %s
section baseline
no_agent (1.468 ms) : 1456, 1479
. : milestone, 1468,
appsec (3.797 ms) : 3575, 4019
. : milestone, 3797,
iast (2.236 ms) : 2168, 2304
. : milestone, 2236,
iast_GLOBAL (2.285 ms) : 2216, 2355
. : milestone, 2285,
profiling (2.066 ms) : 2012, 2120
. : milestone, 2066,
tracing (2.046 ms) : 1993, 2099
. : milestone, 2046,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.501 ms) : 2447, 2556
. : milestone, 2501,
iast (2.237 ms) : 2169, 2305
. : milestone, 2237,
iast_GLOBAL (2.288 ms) : 2219, 2357
. : milestone, 2288,
profiling (2.099 ms) : 2043, 2155
. : milestone, 2099,
tracing (2.045 ms) : 1993, 2098
. : milestone, 2045,
|
Contributor
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
👏 praise: Thanks for taking care of it!
I left few comments, especially around the migrated-modules.txt on master.
❔ question: I saw there was 2 comments, one for warnings, one for regressions.
I wonder if it would not be easier to have a single one? You can generate its content (both warnings and regression) and:
- add/update the unique comment if there is one or the other + fail the check
- delete the unique comment if present otherwise
How does it sound?
🎯 suggestion: Additionally, you can update the skill to ask to update the migrated-modules.txt file once module migration is complete.
Contributor
|
@codex review |
Contributor
|
I asked additional review from Codex as I'm not well versed in reviewing Node JS code from Yaml files 😅 |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8164b95343
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Author
It makes more sense IMO to separate the logic of the comments -- in particular, the regressions comment fails the workflow and needs to be addressed / deleted, whereas the warnings comment is just a recommendation. With separation, each comment can be individually updated instead of having to check the combined content. This may make the PR initially more cluttered with two comments, but at least one of them will be deleted eventually. 🤔 |
sarahchen6
added
tag: override-groovy-enforcement
PerfectSlayer
approved these changes
Mar 4, 2026
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
bot
merged commit 1108a4f
into
master
740 of 742 checks passed
gh-worker-dd-mergequeue-cf854d
bot
deleted the
sarahchen6/workflow-to-enforce-no-groovy
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Add a new Github Action workflow that prevents new Groovy test files from creation. Specifically, this workflow:
.github/migrated-modules.txt. The expectation is that all fully-migrated modules are listed in.github/migrated-modules.txt.dd-smoke-testsanddd-java-agent/instrumentationsare excluded from this.override-groovy-enforcementlabel to this PR.Motivation
During our broader effort to migrate Groovy test files to Java, we should not introduce further regressions. Since
dd-smoke-testsanddd-java-agent/instrumentationsare latter priorities, we excluded them from these checks for now.Additional Notes
The workflow needs to be merged to
masterbefore testing.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.