Skip to content

[nodejs] Revert flaky flag on Node.js Security Control test#5673

Merged
CarlesDD merged 5 commits intomainfrom
ccapell/nodejs-revert-flaky-flag-sec-control-test
Nov 27, 2025
Merged

[nodejs] Revert flaky flag on Node.js Security Control test#5673
CarlesDD merged 5 commits intomainfrom
ccapell/nodejs-revert-flaky-flag-sec-control-test

Conversation

@CarlesDD
Copy link
Contributor

@CarlesDD CarlesDD commented Nov 6, 2025

Motivation

Flakiness is gone

Changes

Revert flaky flag in Node.js manifest and add flaky decorator to state flakiness for version range

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

APPSEC-58724

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

CODEOWNERS have been resolved as:

manifests/nodejs.yml                                                    @DataDog/dd-trace-js
tests/appsec/iast/test_security_controls.py                             @DataDog/asm-libraries @DataDog/system-tests-core

@CarlesDD CarlesDD self-assigned this Nov 6, 2025
@CarlesDD CarlesDD changed the title [nodejs@ccapell/upgrade-iast-taint-tracking-v4.1] Revert flaky flag on Node.js Security Control test [nodejs] Revert flaky flag on Node.js Security Control test Nov 7, 2025
@CarlesDD CarlesDD marked this pull request as ready for review November 27, 2025 11:23
@CarlesDD CarlesDD requested review from a team as code owners November 27, 2025 11:23
@CarlesDD CarlesDD merged commit 1d350d8 into main Nov 27, 2025
53 checks passed
@CarlesDD CarlesDD deleted the ccapell/nodejs-revert-flaky-flag-sec-control-test branch November 27, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants