Skip to content

[nodejs] Revert flaky flag on Node.js Security Control test #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlesDD merged 5 commits into from
Nov 27, 2025
Merged

[nodejs] Revert flaky flag on Node.js Security Control test #5673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fecea87
Revert flaky flag on Node.js Security Control test
CarlesDD Nov 6, 2025
42e73cd
Merge branch 'main' into ccapell/nodejs-revert-flaky-flag-sec-control…
CarlesDD Nov 7, 2025
2679653
Merge branch 'main' into ccapell/nodejs-revert-flaky-flag-sec-control…
CarlesDD Nov 27, 2025
6da97bc
Add flaky decorator to security controls test
CarlesDD Nov 27, 2025
2da969f
Fix import
CarlesDD Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ tests/:
test_security_controls.py:
TestSecurityControls:
'*': *ref_5_37_0
fastify: flaky (APPSEC-58724)
fastify: *ref_5_61_0
nextjs: missing_feature
rasp/:
test_api10.py:
Expand Down
3 changes: 2 additions & 1 deletion tests/appsec/iast/test_security_controls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
# This product includes software developed at Datadog (https://www.datadoghq.com/).
# Copyright 2021 Datadog, Inc.

from utils import features, rfc, weblog, irrelevant
from utils import features, rfc, weblog, irrelevant, flaky, context
from tests.appsec.iast.utils import BaseSinkTest, assert_iast_vulnerability, assert_metric
from utils._weblog import HttpResponse


@features.iast_security_controls
@rfc("https://docs.google.com/document/d/1j1hp87-2wJnXUGADZxzLnvKJmaF_Gd6ZR1hPS3LVguQ/edit?pli=1&tab=t.0")
@flaky(context.library <= "nodejs@5.80" and context.weblog_variant == "fastify", reason="APPSEC-58724")
class TestSecurityControls:
@staticmethod
def assert_iast_is_enabled(request: HttpResponse) -> None:
Expand Down
Loading