Skip to content

Add support for setting apiMaxLength#592

Merged
hardillb merged 3 commits intomainfrom
support-maxApiLength
Mar 5, 2026
Merged

Add support for setting apiMaxLength#592
hardillb merged 3 commits intomainfrom
support-maxApiLength

Conversation

@hardillb
Copy link
Contributor

@hardillb hardillb commented Mar 4, 2026

fixes #590

Description

adds support for increasing the apiMaxLength Node-RED settings (also sets the max dashboard payload for file uploads) This matches hosted instance settings.

There will be a matching FlowFuse PR to add the settings to the UI

Related Issue(s)

#590

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@hardillb hardillb requested a review from Steve-Mcl March 4, 2026 17:32
@hardillb hardillb self-assigned this Mar 4, 2026
@hardillb
Copy link
Contributor Author

hardillb commented Mar 4, 2026

depends on FlowFuse/flowfuse#6799

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh - wait

@hardillb
Copy link
Contributor Author

hardillb commented Mar 4, 2026

@Steve-Mcl what are we waiting for? I've fixed the tests

@hardillb hardillb requested a review from Steve-Mcl March 5, 2026 10:26
@Steve-Mcl
Copy link
Contributor

Since I struggled to parse this all back into my head i pulled and wrote a unit test:

File test/unit/lib/template-settings_spec.js

  template-settings
    ✔ should set the apiMaxLength and ui.maxHttpBufferSize option if provided

Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hardillb

Please check the test I have written in https://github.com/FlowFuse/device-agent/pull/592/changes#diff-6d9077f85bcb74eefb87763266aa0e5ad4d2d22ee063aa6b0eb5022173ad99f7

I believe this is the correct order of events but as you have been in this area i need you to double check it.

I will pre-approve the PR on the assumption my assumptions were right ;)

@hardillb hardillb merged commit 81c0ac0 into main Mar 5, 2026
8 checks passed
@hardillb hardillb deleted the support-maxApiLength branch March 5, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add apiMaxLength to template-settings.js

2 participants