Skip to content

Add UI for device apiMaxLength#6799

Merged
hardillb merged 13 commits intomainfrom
device-api-max-length
Mar 5, 2026
Merged

Add UI for device apiMaxLength#6799
hardillb merged 13 commits intomainfrom
device-api-max-length

Conversation

@hardillb
Copy link
Contributor

@hardillb hardillb commented Mar 4, 2026

fixes #6795

Description

Adds UI for Remote Instance setting apiMaxLength (and coresponding dashboard setting) under Remote Instance -> Settings -> Editor

Needs making pretty

Related Issue(s)

#6795

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production
  • Link to Changelog Entry PR, or note why one is not needed.

Labels

  • Includes a DB migration? -> add the area:migration label

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (d66318c) to head (587d180).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6799   +/-   ##
=======================================
  Coverage   76.60%   76.60%           
=======================================
  Files         398      398           
  Lines       20122    20122           
  Branches     4844     4844           
=======================================
  Hits        15414    15414           
  Misses       4708     4708           
Flag Coverage Δ
backend 76.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hardillb
Copy link
Contributor Author

hardillb commented Mar 4, 2026

depends on FlowFuse/device-agent#592 (and a version bump to 3.8.3 or better)

@hardillb hardillb marked this pull request as ready for review March 5, 2026 10:02
Copy link
Contributor

@cstns cstns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what i have so far, need to trick the DA agent to install the 3.8.4v locally before I'll have a complete overview.

I'll pitch in and implement my observations so far

@cstns cstns self-requested a review March 5, 2026 12:49
@cstns
Copy link
Contributor

cstns commented Mar 5, 2026

tested locally

@hardillb hardillb merged commit acf04b8 into main Mar 5, 2026
36 of 38 checks passed
@hardillb hardillb deleted the device-api-max-length branch March 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Editor Settings with maxApiLength to Remote Instance Settings section

3 participants