Implement otherwise and combinating tests from XQ4 #660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Total files change +1.41KB +0.9% Final result: ✅ View report in BundleMon website ➡️ |
DrRataplan
force-pushed
the
xquery-next
branch
2 times, most recently
from
9336e4c to
b2d34d4
Compare
bwrrp
requested changes
Nov 1, 2024
Member
bwrrp
left a comment
bwrrp
left a comment
There was a problem hiding this comment.
Nice to see some 4.0 features! Left a few smaller comments.
Not sure what's going on with the tests though, most seem to simply require an update of the expected error, but something might have gone wrong with function calls?
| "ci-xqutstestsxqueryx": "cross-env TS_NODE_PROJECT=test/tsconfig.json nyc --no-clean --require ts-node/register --require tsconfig-paths/register mocha --paths test/xqutsTestsXQueryX.ts", | ||
| "coverage": "nyc report --reporter=text-lcov", | ||
| "integrationtests": "ts-mocha --require test/testhook.js \"test/specs/parsing/**/*.ts\" --parallel", | ||
| "integrationtests": "ts-mocha --require test/testhook.js \"test/specs/parsing/**/*.ts\"", |
Member
There was a problem hiding this comment.
was this intentional or removed for debugging?
Contributor
Author
There was a problem hiding this comment.
Intentional. the parallel hides easy to fix errors behind confusing errors. It's CI, so a bit slower is fine
| const ast = | ||
| typeof xpathExpression === 'string' | ||
| ? parseExpression(xpathExpression, { allowXQuery: false }) | ||
| ? parseExpression(xpathExpression, { allowXQuery: false, version: 4 }) |
Member
There was a problem hiding this comment.
Should this depend on the options?
In that case we'd probably also need separate caches for the 3.1 vs 4 expressions.
Seems to cause issues in CI
DrRataplan
force-pushed
the
xquery-next
branch
from
b2d34d4 to
acc9511
Compare
Unsure why this is not wrong, but it makes sense: the unminified fontoxpath is used alongside the minified one. These have different state (registered functions)
DrRataplan
force-pushed
the
xquery-next
branch
from
4d7c773 to
936ad5d
Compare
DrRataplan
force-pushed
the
xquery-next
branch
from
936ad5d to
b520bac
Compare
bwrrp
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.