Revert "Modify Backup URL in Reconciler (#2347)"

[millasml]

This reverts commit b1e744e.

Reverting this because of apple/foundationdb#12544

modifying backups will cause encryption to break

Description

Please include a summary of the change and which issue is addressed. If this change resolves an issue, please include the issue number in the description.

Type of change

Please select one of the options below.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation
• Other

Discussion

Are there any design details that you would like to discuss further?

Testing

Please describe the tests that you ran to verify your changes. Unit tests?
Manual testing?

Do we need to perform additional testing once this is merged, or perform in a larger testing environment?

Documentation

Did you update relevant documentation within this repository?

If this change is adding new functionality, do we need to describe it in our user manual?

If this change is adding or removing subreconcilers, have we updated the core technical design doc to reflect that?

If this change is adding new safety checks or new potential failure modes, have we documented and how to debug potential issues?

Follow-up

Are there any follow-up issues that we should pursue in the future?

Does this introduce new defaults that we should re-evaluate in the future?

[johscheuer]

Instead of reverting the PR, which doesn't fix the issue and still exposes a risk when changing the snapshot duration, I would prefer to skip the modify backup sub reconciler when encryption is enabled.