Skip to content

Conversation

@alexlichtenstein
Copy link
Collaborator

@alexlichtenstein alexlichtenstein commented May 25, 2022


@micahcarroll
Copy link
Member

Thanks Alex for the first PR! 🚀

One thing that is not clear from the above: did you perform any checks to see whether the changes in the requirements file don't break anything downstream? Might be useful to document that in the PR.

Also, generally it might be useful to split PRs by individual features added / issues addressed. In this case it doesn't really matter because both issues are very small, but the PR name only covers one of the changes.

@micahcarroll
Copy link
Member

Hi Alex, just as another comment here, the .github/workflows/check_code.yml file is empty – I'm guessing this was a mistake?

@micahcarroll micahcarroll mentioned this pull request Jun 2, 2022
@micahcarroll micahcarroll changed the title corrections to the requirements file (issue #32) Corrections to the requirements file (issue #32) and additional information about human-human gameplay Jun 2, 2022
@micahcarroll
Copy link
Member

Hi @alexlichtenstein, we should probably delete the .github/workflows/check_code.yml file from this PR (as we're dealing with that in #38). We can then update the human-human gameplay instructions, and merge this in, so we unblock #38 from being merged too.

Changes to the description for human-human interaction
Copy link
Member

@micahcarroll micahcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@micahcarroll micahcarroll merged commit adf5c38 into master Jun 15, 2022
@micahcarroll micahcarroll deleted the alex_dev branch June 15, 2022 22:25
This was linked to issues Jun 15, 2022
This was referenced Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Human-Human play cannot import name 'escape' from 'jinja2'

4 participants