-
Notifications
You must be signed in to change notification settings - Fork 27
Corrections to the requirements file (issue #32) and additional information about human-human gameplay #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks Alex for the first PR! 🚀 One thing that is not clear from the above: did you perform any checks to see whether the changes in the requirements file don't break anything downstream? Might be useful to document that in the PR. Also, generally it might be useful to split PRs by individual features added / issues addressed. In this case it doesn't really matter because both issues are very small, but the PR name only covers one of the changes. |
|
Hi Alex, just as another comment here, the |
2c09f60 to
2385891
Compare
|
Hi @alexlichtenstein, we should probably delete the |
This reverts commit 76f2774.
Changes to the description for human-human interaction
micahcarroll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Uh oh!
There was an error while loading. Please reload this page.