Skip to content

Conversation

@alexlichtenstein
Copy link
Collaborator

Added black and isort pre-commit github action

@micahcarroll
Copy link
Member

Once this is merged, we should probably also add it to the overcooked-ai repo, where it's going to be most relevant after the repo merge

Copy link
Member

@micahcarroll micahcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, but we should wait on #35 to be completed before merging this!

Comment on lines +55 to +59
## Use the human vs. human game mode.

With the Overcooked demo you can test the interaction between two human players. To do this, select the human keyboard input for both players and click on "Create Game", it will display "Waiting for game to start". Open another tab and navigate to http://localhost/psyturk to start the game.
The first user can be controlled from the same page, the other user from another tab (http://localhost/psiturk).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge #35 before merging these changes, so we can merge master into this branch with the correctly updated human-human instructions before merging this PR.

@micahcarroll
Copy link
Member

Also, other thing that needs to be done before we can merge this is to have the status checks pass! I would wait for #35 to be merged (and merging master into this branch) before running the formatter for all files.

@micahcarroll
Copy link
Member

Actually, we might want to deal with #34 before merging this PR, as the diffs will be much simpler before formatting is applied everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants