Skip to content

Conversation

@isovector
Copy link

@isovector isovector commented Nov 18, 2025

Description

The previous implementation would fail to parse the emitted JSON. Fixes tweag/ouroboros-consensus-testing#14

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@crocodile-dentist
Copy link
Contributor

Please create a scriv fragment for changelog, run stylish-haskell and squash the commits.

@isovector isovector force-pushed the isovector/diffusionmode-json branch from 2e865e7 to 41f40e1 Compare November 19, 2025 15:48
@isovector isovector force-pushed the isovector/diffusionmode-json branch from 41f40e1 to 1f4f676 Compare November 19, 2025 15:50
Copy link
Contributor

@crocodile-dentist crocodile-dentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[BUG] - cardano-node cannot parse the generated topology file

2 participants