Skip to content

Fix ToJSON instance for DiffusionMode #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −1
Open

Fix ToJSON instance for DiffusionMode #5245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions ouroboros-network/changelog.d/20251119_074504_isovector_fix_diffusion_mode.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<!--
A new scriv changelog fragment.
Uncomment the section that is right (remove the HTML comment wrapper).
For top level release notes, leave all the headers commented out.
-->


### Breaking

- Changed ToJSON for DiffusionMode to agree with the topology file syntax. ReadJSON was already correct.


<!--
### Non-Breaking
- A bullet item for the Non-Breaking category.
-->
3 changes: 2 additions & 1 deletion ouroboros-network/orphan-instances/Ouroboros/Network/OrphanInstances.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ instance FromJSON DiffusionMode where
_ -> fail "Parsing NodeDiffusionMode failed: can be either 'InitiatorOnly' or 'InitiatorAndResponder'"

instance ToJSON DiffusionMode where
toJSON = String . pack . show
toJSON InitiatorOnlyDiffusionMode = "InitiatorOnly"
toJSON InitiatorAndResponderDiffusionMode = "InitiatorAndResponder"

-- | Does not use the 'FromJSON' instance of 'RootConfig', so that
-- 'accessPoints', 'advertise', 'valency' and 'warmValency' fields are attached
Expand Down