Open
Conversation
They were more hassle (causing merge conflicts all the time) than useful (it's not too cumbersome to just search the codebase for the `msgid` strings anyway), so decided to remove them.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
==========================================
+ Coverage 88.00% 88.16% +0.15%
==========================================
Files 153 153
Lines 6246 6235 -11
==========================================
Hits 5497 5497
+ Misses 749 738 -11
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
#:comments in.pofiles (d07e521)msgidstrings anyway), so decided to remove them.#, fuzzymsgstrs could help, and since the matching is so often very wrong - which can cause a lot of user confusion if not caught - it's easier for us to just not do any fuzzy matching and instead always generate new, blank translations. This does mean that if you runmakemessagesafter changing e.g. one character in an existing message in the code, the previousmsgstrwill be wiped - albeit with the previousmsgidandmsgstrcommented out with#~and moved to the bottom of the.pofile.makemessagesnot ignoring the JSlibfolder (09699e3)Review guidance
Checklist
(If any of the points are not relevant, mark them as checked, so that it's easy to see which points you've handled or not)
makemigrations,makemessagesandcompilemessages