Skip to content

Fixes issue #6727 : Back to default WASD centered keybinds #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Seekawan wants to merge 1 commit into
base: main
Choose a base branch
from
+45 −45
Draft

Fixes issue #6727 : Back to default WASD centered keybinds #8124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 45 additions & 45 deletions megamek/mmconf/defaultKeyBinds.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@
</KeyBind>

<KeyBind>
<command>toggleChat</command> <!-- Enter -->
<keyCode>10</keyCode>
<command>toggleChat</command> <!-- Backquote -->
<keyCode>192</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
Comment on lines +32 to 35
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toggleChat is changed from Enter (10) to Backquote (192). This diverges from the built-in default in KeyCommandBind (VK_ENTER) and is likely to surprise users who expect Enter to open chat. If the intent is only to restore the documented weapon/target cycling defaults (issue #6727), consider keeping chat on Enter.

Copilot uses AI. Check for mistakes.
</KeyBind>
Expand Down Expand Up @@ -99,85 +99,85 @@
</KeyBind>

<KeyBind>
<command>nextWeapon</command> <!-- Down -->
<keyCode>40</keyCode>
<command>nextWeapon</command> <!-- E -->
<keyCode>69</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>prevWeapon</command> <!-- Up -->
<keyCode>38</keyCode>
<command>prevWeapon</command> <!-- Q -->
<keyCode>81</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextUnit</command> <!-- Tab -->
<keyCode>9</keyCode>
<modifier>0</modifier>
<command>nextUnit</command> <!-- Shift+E -->
<keyCode>69</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>prevUnit</command> <!-- Shift+Tab -->
<keyCode>9</keyCode>
<command>prevUnit</command> <!-- Shift+Q -->
<keyCode>81</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextTarget</command> <!-- Right -->
<keyCode>39</keyCode>
<command>nextTarget</command> <!-- C -->
<keyCode>67</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Comment on lines +130 to 134
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nextTarget is rebound to C, but sensorRange already uses C as a CommonMenuBar accelerator. Because non-menu binds are handled by the global KeyEventDispatcher (and consume the event), this will effectively disable the sensorRange shortcut by default. Consider choosing a different key for nextTarget or moving sensorRange off C.

Copilot uses AI. Check for mistakes.

<KeyBind>
<command>prevTarget</command> <!-- Left -->
<keyCode>37</keyCode>
<command>prevTarget</command> <!-- Z -->
<keyCode>90</keyCode>
Comment on lines +137 to +138
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prevTarget is rebound to Z, but zoomOverviewToggle is also bound to Z (CommonMenuBar accelerator). Since prevTarget is handled by the global key dispatcher, it will consume Z and prevent the zoom overview toggle accelerator from firing. One of these defaults needs to move to avoid making zoomOverviewToggle unreachable.

Suggested change
<command>prevTarget</command> <!-- Z -->
<keyCode>90</keyCode>
<command>prevTarget</command> <!-- X -->
<keyCode>88</keyCode>

Copilot uses AI. Check for mistakes.
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextTargetValid</command> <!-- Shift+Right -->
<keyCode>39</keyCode>
<command>nextTargetValid</command> <!-- Shift+C -->
<keyCode>67</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>prevTargetValid</command> <!-- Shift+Left -->
<keyCode>37</keyCode>
<command>prevTargetValid</command> <!-- Shift+Z -->
<keyCode>90</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextTargetNoAllies</command> <!-- Ctrl+Right -->
<keyCode>39</keyCode>
<command>nextTargetNoAllies</command> <!-- Ctrl+C -->
<keyCode>67</keyCode>
<modifier>128</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>prevTargetNoAllies</command> <!-- Ctrl+Left -->
<keyCode>37</keyCode>
<command>prevTargetNoAllies</command> <!-- Ctrl+Z -->
<keyCode>90</keyCode>
<modifier>128</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextTargetValidNoAllies</command> <!-- Ctrl+Shift+Right -->
<keyCode>39</keyCode>
<command>nextTargetValidNoAllies</command> <!-- Ctrl+Shift+C -->
<keyCode>67</keyCode>
<modifier>192</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>prevTargetValidNoAllies</command> <!-- Ctrl+Shift+Left -->
<keyCode>37</keyCode>
<command>prevTargetValidNoAllies</command> <!-- Ctrl+Shift+Z -->
<keyCode>90</keyCode>
<modifier>192</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Expand Down Expand Up @@ -239,8 +239,8 @@
</KeyBind>

<KeyBind>
<command>autoArtyDeployZone</command> <!-- Shift+Z -->
<keyCode>90</keyCode>
<command>autoArtyDeployZone</command> <!-- Shift+Space -->
<keyCode>32</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Expand Down Expand Up @@ -288,15 +288,15 @@
</KeyBind>

<KeyBind>
<command>udWeapons</command> <!-- F4 -->
<keyCode>115</keyCode>
<command>udWeapons</command> <!-- F5 -->
<keyCode>116</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>udSystems</command> <!-- F5 -->
<keyCode>116</keyCode>
<command>udSystems</command> <!-- F4 -->
<keyCode>115</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Comment on lines +291 to 302
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

udWeapons/udSystems are swapped from the existing defaults (Weapons=F4, Systems=F5 per KeyCommandBind). If the goal is to revert to documented defaults, this swap likely goes the wrong direction and will break muscle memory for the unit display tabs. Consider keeping Weapons on F4 and Systems on F5 unless there’s a specific rationale.

Copilot uses AI. Check for mistakes.
Expand Down Expand Up @@ -344,15 +344,15 @@
</KeyBind>

<KeyBind>
<command>prevMode</command> <!-- Down -->
<keyCode>225</keyCode>
<modifier>0</modifier>
<command>prevMode</command> <!-- Shift+Tab -->
<keyCode>9</keyCode>
<modifier>64</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>nextMode</command> <!-- Up -->
<keyCode>224</keyCode>
<command>nextMode</command> <!-- Tab -->
<keyCode>9</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Expand Down Expand Up @@ -421,9 +421,9 @@
</KeyBind>

<KeyBind>
<command>movementEnvelope</command> <!-- Ctrl+Q -->
<keyCode>81</keyCode>
<modifier>128</modifier>
<command>movementEnvelope</command> <!-- R -->
<keyCode>82</keyCode>
<modifier>0</modifier>
Comment on lines +424 to +426
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

movementEnvelope is now bound to R (82, modifier 0), but fieldOfFire is also bound to R right below. These are CommonMenuBar accelerators, so one of these actions will be unreachable (or the behavior will depend on registration order). Pick a different default for one of them (e.g., keep movementEnvelope on Ctrl+Q as in KeyCommandBind defaults).

Suggested change
<command>movementEnvelope</command> <!-- R -->
<keyCode>82</keyCode>
<modifier>0</modifier>
<command>movementEnvelope</command> <!-- Ctrl+Q -->
<keyCode>81</keyCode>
<modifier>128</modifier>

Copilot uses AI. Check for mistakes.
<isRepeatable>false</isRepeatable>
</KeyBind>

Expand Down Expand Up @@ -526,15 +526,15 @@
</KeyBind>

<KeyBind>
<command>zoomIn</command> <!-- NumPad + -->
<keyCode>107</keyCode>
<command>zoomIn</command> <!-- Plus -->
<keyCode>521</keyCode>
<modifier>0</modifier>
Comment on lines +529 to 531
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zoomIn is changed from NumPad + (VK_ADD/107) to Plus with keyCode 521 and no Shift modifier. On many layouts, the + key is produced as Shift+= (VK_EQUALS) rather than VK_PLUS, so this default may not work consistently across platforms/layouts. Consider keeping VK_ADD, or using the actual keyCode/modifier pair produced by '+' on common layouts (e.g., VK_EQUALS + Shift).

Suggested change
<command>zoomIn</command> <!-- Plus -->
<keyCode>521</keyCode>
<modifier>0</modifier>
<command>zoomIn</command> <!-- Shift+= (Plus) -->
<keyCode>61</keyCode>
<modifier>64</modifier>

Copilot uses AI. Check for mistakes.
<isRepeatable>false</isRepeatable>
</KeyBind>

<KeyBind>
<command>zoomOut</command> <!-- NumPad - -->
<keyCode>109</keyCode>
<command>zoomOut</command> <!-- Minus -->
<keyCode>45</keyCode>
<modifier>0</modifier>
<isRepeatable>false</isRepeatable>
</KeyBind>
Expand Down
Loading