Add filters used for rare disease epidermolysis extract 2024-10 [NDRS3-337] #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenny-lee-1
reviewed
Nov 21, 2024
| # [/MULTI/, /ATROPHY/]].freeze | ||
| # Custom criteria used 2024-10, cf. JIRA NDRS3-337 | ||
| # RD_STRING_PATTERNS = [[/EPIDERMOLYSIS BULLOSA/], | ||
| # [/EPIDERMOLYSIS/]].freeze |
Contributor
There was a problem hiding this comment.
I might be totally misunderstanding the request, but would this match the below string from ticket, if it included the r in epidemolysis? not sure if it's a ticket typo or not.
"Please can the free text 'epidemolysis bullosa acquisita' be excluded."
Contributor
Author
There was a problem hiding this comment.
Yes, it matches the string 'epidemolysis bullosa acquisita'. I ended up removing those manually: if I'd just excluded them in RD_STRING_PATTERNS, many of them would still have matched by ICD code and been included in the output.
I decided it was quicker to remove them manually for this one-off extract, than add an extra codepath for exclusions of free text when the ICD code matches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds filters used for a custom 2024-10 rare disease epidermolysis mortality extract, cf. https://nhsd-jira.digital.nhs.uk/browse/NDRS3-337
We don't want to change the regular rare disease extract filters, so these changes have been added but commented out, so that they can be reproduced if necessary.