Skip to content

Add filters used for rare disease epidermolysis extract 2024-10 [NDRS3-337] #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bshand merged 1 commit into from
May 24, 2025
Merged

Add filters used for rare disease epidermolysis extract 2024-10 [NDRS3-337] #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/export/cancer_death_common.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ class CancerDeathCommon < DeathFile # rubocop:disable Metrics/ClassLength
# Updated criteria implemented 2021-11, cf. plan.io #14947#note-21
# RD_PATTERN = /\A(D761|D762|D763|U10.*|M303|E752)\z
# /x
# Custom criteria used 2024-10, cf. JIRA NDRS3-337
# RD_PATTERN = /\A(Q81.*)\z/
# Updated criteria implemented 2022-09, cf. plan.io #30091 and #14947
RD_PATTERN = /\A(E009|E030|E031|G724|I776|I778|J991|M080|M082|M083|M084|M089|M300|M301|M303|
M308|M313|M314|M315|M316|M317|M321|M328|M329|M330|M331|M332|M339|M340|M341|M348|M349|M352|
Expand All @@ -47,6 +49,8 @@ class CancerDeathCommon < DeathFile # rubocop:disable Metrics/ClassLength
# RD_PATTERN_POST_2015 = /\A(Q.*)\z/
# Updated criteria implemented 2021-11, cf. plan.io #14947#note-21
# RD_PATTERN_POST_2015 = /\AZZZZZZ\z/ # match no ICD codes
# Custom criteria used 2024-10, cf. JIRA NDRS3-337
# RD_PATTERN_POST_2015 = /\A(Q81.*)\z/
# Updated criteria implemented 2022-09, cf. plan.io #30091 and #14947
RD_PATTERN_POST_2015 = /\A(Q.*)\z/
# Extract used until 2020-10
Expand All @@ -55,6 +59,9 @@ class CancerDeathCommon < DeathFile # rubocop:disable Metrics/ClassLength
# [/WOLFRAM/],
# [/DIDMOAD/],
# [/MULTI/, /ATROPHY/]].freeze
# Custom criteria used 2024-10, cf. JIRA NDRS3-337
# RD_STRING_PATTERNS = [[/EPIDERMOLYSIS BULLOSA/],
# [/EPIDERMOLYSIS/]].freeze
Copy link
Contributor

@kenny-lee-1 kenny-lee-1 Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be totally misunderstanding the request, but would this match the below string from ticket, if it included the r in epidemolysis? not sure if it's a ticket typo or not.

"Please can the free text 'epidemolysis bullosa acquisita' be excluded."

Copy link
Contributor Author

@bshand bshand Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it matches the string 'epidemolysis bullosa acquisita'. I ended up removing those manually: if I'd just excluded them in RD_STRING_PATTERNS, many of them would still have matched by ICD code and been included in the output.

I decided it was quicker to remove them manually for this one-off extract, than add an extra codepath for exclusions of free text when the ICD code matches.

# Updated criteria implemented 202x1-10, cf. plan.io #14947#note-18
RD_STRING_PATTERNS = [].freeze
# C / D00-D48, confirmed as sufficient against early 2017 cancer death files
Expand Down
Loading