Edit line to not need safe navigation consideration #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able in ROA importer
shilpigoeldev
requested changes
Dec 12, 2025
Contributor
shilpigoeldev
left a comment
shilpigoeldev
left a comment
There was a problem hiding this comment.
Can a similar approach be taken at line 153, 155 -> /NGS/.match?(exon) and /P003/i.match?(exon) && /dosage/i.match?(moltesttype)
shilpigoeldev
approved these changes
Dec 12, 2025
Contributor
shilpigoeldev
left a comment
shilpigoeldev
left a comment
There was a problem hiding this comment.
LGTM now, but lets have @bshand approval too , thanks
bshand
approved these changes
Dec 12, 2025
Contributor
bshand
left a comment
bshand
left a comment
There was a problem hiding this comment.
Looks good to me, thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the recently added safe navigation to suggested alternative, which means we don't need to think about safe navigation where nil values are allowed to be persisted in the database.
All local tests unaffected by change.