Skip to content

Edit line to not need safe navigation consideration #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NImeson merged 2 commits into from
Dec 12, 2025
Merged

Edit line to not need safe navigation consideration #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fda8e08
amended safe navigation line to improved code - nil values are accept…
NImeson Dec 12, 2025
4d5b047
edited additional lines to reflect same changes
NImeson Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/import/colorectal/providers/manchester/manchester_handler_colorectal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def extract_genes_from_raw_fields
exon = raw_record['exon']
genotype2 = raw_record['genotype2']
next if MSH6_DOSAGE_MTYPE.include?(moltesttype) && !exon.scan(/MLPA/i).size.positive?
next if moltesttype&.match?(/dosage/i) && !exon.match?(/MLPA|P003/i)
next if /dosage/i.match?(moltesttype) && !/MLPA|P003/i.match?(exon)

genes_found << find_genes_genotype(exon, moltesttype, genotype, genotype2)
end
Expand All @@ -150,9 +150,9 @@ def find_genes_genotype(exon, moltesttype, genotype, genotype2)
exon_genes = exon&.scan(COLORECTAL_GENES_REGEX).to_a
genotype_genes = genotype&.scan(COLORECTAL_GENES_REGEX).to_a
genotype2_genes = genotype2&.scan(COLORECTAL_GENES_REGEX).to_a
if exon.match?('NGS')
if /NGS/.match?(exon)
genotype == 'No pathogenic variant identified' ? exon_genes : genotype_genes
elsif exon.match?(/P003/i) && moltesttype&.match?(/dosage/i)
elsif /P003/i.match?(exon) && /dosage/i.match?(moltesttype)
%w[MLH1 MSH2] + [genotype_genes + genotype2_genes]
elsif exon == 'MLH1_MSH2_MSH6_NGS-POOL' &&
genotype == 'No pathogenic variant identified'
Expand Down
Loading