improve yarn/npm installers #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should not be included since we support multiple package managers
gwleuverink
changed the title
gwleuverink
changed the title
No need to throw, PHP trace won't give any relevant output here. Just make clear what process failed. Error output is already echoed above.
PeteBishwhip
reviewed
Nov 5, 2025
|
|
||
| ensureDirSync(binaryDestDir); | ||
|
|
||
| console.log('FOOOOO') |
| if ($result->failed()) { | ||
| echo PHP_EOL; | ||
| error("Command failed: '{$command}' (exit code {$result->exitCode()})"); | ||
| exit(); |
Member
There was a problem hiding this comment.
Include the exit code here in the parenthesis to ensure we don’t return exit 0 (success)
simonhamp
approved these changes
Nov 5, 2025
Collaborator
Author
|
Need one more review on this one @NativePHP/contributors |
PeteBishwhip
approved these changes
Nov 6, 2025
Member
|
Got chu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
yarninstaller.Additionally it now throws an error when a
install,runorbuildcommand fails, no longer failing silently.Removed
packageManagersentry frompackage.jsonThis should not be included since we support multiple package managers
Fixes Run the NativePHP installer with pnpm doesn't work. #29
Removed
yarn.lockWas very old and out of date. Will ensure outdated lock file is not used when using
yarnas the installerThrow when a process in
ExecuteCommand.phpfailsRemoved some debug logs