Skip to content

improve yarn/npm installers #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 6, 2025
+12 −6,642
Merged

improve yarn/npm installers #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f91e941
removed packageManagers from package.json
gwleuverink Oct 28, 2025
26afcaf
throw when ExecuteCommand process fails
gwleuverink Nov 4, 2025
52c5192
remove debug logs
gwleuverink Nov 4, 2025
bc91b2f
remove yarn.lock (was very old and out of date)
gwleuverink Nov 4, 2025
78629f6
improve error output
gwleuverink Nov 4, 2025
93a62a8
Improve error output.
gwleuverink Nov 4, 2025
7ed3679
forward exit code
gwleuverink Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions resources/electron/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,5 @@
"exports": "./electron-plugin/dist/index.js",
"imports": {
"#plugin": "./electron-plugin/dist/index.js"
},
"packageManager": "yarn@1.22.22+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
}
3 changes: 0 additions & 3 deletions resources/electron/php.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ if (platform.phpBinary) {

ensureDirSync(binaryDestDir);

console.log('FOOOOO')
Copy link
Member

@PeteBishwhip PeteBishwhip Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. 😅

Copy link
Collaborator Author

@gwleuverink gwleuverink Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know 🫠 haha

console.dir(binarySrcDir);

// Unzip the files
unzip.open(binarySrcDir, {lazyEntries: true}, function (err, zipfile) {
if (err) throw err;
Expand Down
Loading
Loading