neo_worldpos_marker and neo_npc_targetsystem penetration

[DESTROYGIRL]

Description

• Makes jeff fire bullets using the same method as players, allowing for penetration
• Adds an entity for displaying points of interest on the HUD like ghost caps. Functions similarly to neo_controlpoint from OG and is backwards compatible with maps that used it

Toolchain

• Windows MSVC VS2022

Linked Issues

• fixes The team logo above Jeff the tank should not be influenced by HDR #1372

[Rainyan]

Nit: since we're repeating these lines for both the "if" and the "else", could simplify by removing the else branch entirely, and just executing these lines unconditionally at the end of the function:

-
-               const float halfArrowLength = HALF_BASE_TEX_LENGTH * scale;
-               vgui::surface()->DrawSetColor(targetColor);
-               vgui::surface()->DrawTexturedRect(
-                       x - halfArrowLength,
-                       y - halfArrowLength,
-                       x + halfArrowLength,
-                       y + halfArrowLength);
-       }
-       else
-       {
-               const float halfArrowLength = HALF_BASE_TEX_LENGTH * scale;
-               vgui::surface()->DrawSetColor( targetColor );
-               vgui::surface()->DrawTexturedRect(
-                       x - halfArrowLength,
-                       y - halfArrowLength,
-                       x + halfArrowLength,
-                       y + halfArrowLength);
        }
+       const float halfArrowLength = HALF_BASE_TEX_LENGTH * scale;
+       vgui::surface()->DrawSetColor(targetColor);
+       vgui::surface()->DrawTexturedRect(
+               x - halfArrowLength,
+               y - halfArrowLength,
+               x + halfArrowLength,
+               y + halfArrowLength);

[Rainyan]

Nit: this could be assert_cast, since it will be faster for Release builds but still does the Assert for Debug. Line 1759 on the other hand definitely should remain a dynamic_cast, since we do test the nullptr case for it.

[Rainyan]

Nit: this run-time Assert could be changed to compile-time static_assert (or alternatively COMPILE_TIME_ASSERT, which is a convenience wrapper around static_assert)

[Rainyan]

Nit: would prefer if we specify override explicitly

[Rainyan]

Nit: maybe initialize m_hFont as vgui::INVALID_FONT, instead of using the magic value 0UL

[Rainyan]

Nit: probably redundant Assert, since the if-condition above already checks for this