Conversation
Member
Author
|
fixes #163134 |
Member
Author
|
@doronbehar you should be happy this makes the libluv packaging a bit clearer IMHO. |
added 5 commits
March 29, 2022 03:18
as required by neovim master
to avoid the error 'cfg.root_dir is null' see luarocks/luarocks#1161 for details
some linker flags have been added to support declarative treesitter grammars but the justification is fuzzy and it breaks several stuff on nix see NixOS#147658
Contributor
|
Thanks a lot @teto for the hard work! Well done. I pushed a few additions to the neovim expression. |
72d210c to
258fc2b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Remove unneeded cmakeFlags and explain more what is the difference between lua.pkgs.libluv and lua.pkgs.luv.
258fc2b to
f80b906
Compare
teto
commented
Mar 29, 2022
31 tasks
Member
Author
|
I've just checked with and without your commits, the functional tests start which is what I wanted to make sure. As far as I am concerned it's ok to merge. If a darwin user could confirm it works, we could merge. |
Member
Author
looks good. Some of the errors come from packages using the wrong lua version I guess |
Member
Author
|
seems to pass CI on darwin, merging. |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to hack on neovim but got held up by several things. Trying to address those here while improving lua ecosystem at the same time.
Related:
#80528
#141718
Fixes #163134 .
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes