[Backport release-24.05] brainflow: init at 5.12.1#328019
Merged
JohnRTitor merged 2 commits intorelease-24.05from Jul 18, 2024
Merged
[Backport release-24.05] brainflow: init at 5.12.1#328019JohnRTitor merged 2 commits intorelease-24.05from
JohnRTitor merged 2 commits intorelease-24.05from
Conversation
added 2 commits
July 17, 2024 20:52
13 tasks
ofborg
bot
added
10.rebuild-darwin: 1-10
AndersonTorres
approved these changes
Jul 17, 2024
| }) | ||
| ]; | ||
|
|
||
| cmakeFlags = with lib; [ |
Member
There was a problem hiding this comment.
Hey @AndersonTorres, it seems like you're frustrated from seeing this pattern too often, but I don't think it's appropriate to use a smiley face as feedback regardless. Especially when seen by newer contributors, this just makes for an uninviting atmosphere, so I'd appreciate it if you could improve on that 🙂
In this case I'd recommend something like
Using
with lib;is often not recommended, see also #330035. I don't think it's necessary here.Suggested change
cmakeFlags = with lib; [ cmakeFlags = [
If you don't want to type this all the time, you could also (in increasing order of difficulty):
- Use saved replies to not have to type the same response all the time
- Make a PR to document best practices regarding
within Nixpkgs, which both solidifies it as a convention for others to propagate, but also allows you to link to it - Help creating automation to enforce such conventions automatically
- Fix the underlying problem, e.g. by pushing [RFC 0110] Add "inherit-as-list" syntax construct to the Nix language rfcs#110
Pandapip1
approved these changes
Jul 18, 2024
Member
Pandapip1
left a comment
Pandapip1
left a comment
There was a problem hiding this comment.
+1 from me, as the person that added the backport label in the first place
Pandapip1
added
the
12.approvals: 2
13 tasks
github-actions
bot
added
the
6.topic: python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.05, triggered by a label in #324462.