[19.0][MIG] impersonate_login: Migration to 19.0 #849

tishmen · 2025-10-10T19:55:34Z

Scope

impersonate_login

Depends on

None

Summary

Migration to Odoo 19.0; tests included. No functional changes beyond compatibility.
History preserved via git format-patch --keep-subject from upstream/18.0 and git am -3 --keep onto upstream/19.0.
Commit structure kept clean for review:
- [IMP] pre-commit auto fixes (single commit)
- [MIG] migration to 19.0 (single commit)

Changes (highlights)

Use self.env._ for translations and lazy placeholders where needed.
Replace deprecated self._uid with self.env.uid.
Adapt mail.thread override to 19.0 signature: _message_compute_author(self, author_id=None, email_from=None).
Avoid attribute access on request.session; use session.get("impersonate_from_uid").
Security XML: res.groups field renamed to user_ids.
Manifest: version bumped to 19.0.1.0.0, website points to 19.0 path.
JS: backend user menu integration kept; prettier/eslint auto-fixes applied.
Tests: resilient on 19.0 runner (no demo data by default) – create demo user and grant required groups (base.group_user, base.group_partner_manager).

Temporary references

None

Pre-commit

Ran locally; auto-fixes committed as a single [IMP] commit.

Tests

Locally verified with fresh DB using --test-tags "/impersonate_login".
CI is expected to run pre-commit and the module tests against Odoo 19 and OCB.

Review

Files changed show the result on top of 19.0. For an easier review, consider commit-by-commit: import history (via am) → [IMP] pre-commit → [MIG] migration.

Currently translated at 100.0% (25 of 25 strings) Translation: server-auth-17.0/server-auth-17.0-impersonate_login Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-impersonate_login/it/

tishmen · 2025-10-10T20:00:20Z

@legalsylvain Opened a new PR based on the OCA 18.0 → 19.0 migration guidelines: #849. It preserves history via format-patch/am from upstream/18.0, with two commits ([IMP] pre-commit auto-fixes, [MIG] migration). Please review commit-by-commit. I am closing the previous PR as this current approach looks good.

legalsylvain

Diff review. LGTM, but I don't use this module, so I let authors make a deeper review.

Two minors remarks inline.

Thanks a bot for the work.

impersonate_login/models/ir_http.py

impersonate_login/models/mail_thread.py

tishmen · 2025-10-15T08:26:15Z

Hi @legalsylvain, sorry for the late response. I’ve resolved the noted issues and pushed the updates. Thanks for the review! Please let me know if you spot anything else.

tishmen · 2025-10-15T08:28:29Z

All remarks resolved and CI is green. @Kev-Roche @astirpe @mymage mind giving this a second review?

mymage

RunBoat functional OK

CasVissers-360ERP

Functional review

OCA-git-bot · 2025-11-03T09:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

StefanRijnhart

Thanks! Just some small nitpicks. And please squash the follow-up commit.

impersonate_login/tests/test_impersonate_login.py

impersonate_login/security/group.xml

RyanTranAVB

Code LGTM

tishmen · 2025-12-21T21:49:35Z

Sorry for the delay — I’ve implemented the changes you requested. Thanks for the review!

StefanRijnhart · 2025-12-22T16:56:59Z

@tishmen Thank you, but please squash the two follow-up commits into the migration commit.

tishmen · 2025-12-28T11:05:47Z

@StefanRijnhart I squashed the two follow-up commits into the migration commit and force-pushed the updated branch. Thanks!

StefanRijnhart

Thanks!

/ocabot merge nobump

OCA-git-bot · 2025-12-28T11:46:42Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 19.0-ocabot-merge-pr-849-by-StefanRijnhart-bump-nobump, awaiting test results.

StefanRijnhart · 2025-12-28T11:46:54Z

/ocabot migration impersonate_login

OCA-git-bot · 2025-12-28T11:50:53Z

Congratulations, your PR was merged at ac5a825. Thanks a lot for contributing to OCA. ❤️

Kev-Roche and others added 16 commits October 10, 2025 21:48

[14.0][ADD] impersonate_login

f171369

[MIG] impersonate_login: pre-commit

245f16d

[MIG] impersonate_login: migration to V17

655efdd

[UPD] Update impersonate_login.pot

c1887aa

[BOT] post-merge updates

f980c9d

[FIX] impersonate_login: fix computed body field + add inverse

5285e62

Added translation using Weblate (Italian)

0dabe49

Translated using Weblate (Italian)

5402ece

Currently translated at 100.0% (25 of 25 strings) Translation: server-auth-17.0/server-auth-17.0-impersonate_login Translate-URL: https://translation.odoo-community.org/projects/server-auth-17-0/server-auth-17-0-impersonate_login/it/

[UPD] Update impersonate_login.pot

e87bbf1

[BOT] post-merge updates

4e885d2

[FIX] impersonate_login: fix user_id comodel_name

49124a8

[BOT] post-merge updates

0f743bc

[MIG] impersonate_login: pre-commit

59ea67b

[MIG] impersonate_login: migrate to V18

9ee630e

[UPD] Update impersonate_login.pot

50b93ce

[BOT] post-merge updates

7f9ff99

tishmen mentioned this pull request Oct 10, 2025

[19.0] [MIG] impersonate_login: migrate + tests #847

Closed

legalsylvain reviewed Oct 10, 2025

View reviewed changes

impersonate_login/models/ir_http.py Outdated Show resolved Hide resolved

impersonate_login/models/mail_thread.py Outdated Show resolved Hide resolved

mymage approved these changes Oct 15, 2025

View reviewed changes

CasVissers-360ERP approved these changes Nov 3, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Nov 3, 2025

StefanRijnhart reviewed Nov 27, 2025

View reviewed changes

impersonate_login/tests/test_impersonate_login.py Outdated Show resolved Hide resolved

impersonate_login/tests/test_impersonate_login.py Outdated Show resolved Hide resolved

impersonate_login/security/group.xml Outdated Show resolved Hide resolved

RyanTranAVB approved these changes Dec 1, 2025

View reviewed changes

tishmen force-pushed the 19.0-mig-impersonate_login branch from 8e2444b to 9aca0dd Compare December 21, 2025 21:48

[MIG] impersonate_login: Migration to 19.0

b6b92f9

tishmen force-pushed the 19.0-mig-impersonate_login branch from 9aca0dd to b6b92f9 Compare December 28, 2025 11:03

StefanRijnhart approved these changes Dec 28, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 28, 2025

OCA-git-bot added this to the 19.0 milestone Dec 28, 2025

OCA-git-bot mentioned this pull request Dec 28, 2025

Migration to version 19.0 #842

Open

19 tasks

OCA-git-bot merged commit 118db7d into OCA:19.0 Dec 28, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 28, 2025

Uh oh!

[19.0][MIG] impersonate_login: Migration to 19.0 #849

[19.0][MIG] impersonate_login: Migration to 19.0 #849

Uh oh!

Conversation

tishmen commented Oct 10, 2025

Uh oh!

tishmen commented Oct 10, 2025

Uh oh!

legalsylvain left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tishmen commented Oct 15, 2025

Uh oh!

tishmen commented Oct 15, 2025

Uh oh!

mymage left a comment

Choose a reason for hiding this comment

Uh oh!

CasVissers-360ERP left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 3, 2025

Uh oh!

StefanRijnhart left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RyanTranAVB left a comment

Choose a reason for hiding this comment

Uh oh!

tishmen commented Dec 21, 2025

Uh oh!

StefanRijnhart commented Dec 22, 2025

Uh oh!

tishmen commented Dec 28, 2025

Uh oh!

StefanRijnhart left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Dec 28, 2025

Uh oh!

StefanRijnhart commented Dec 28, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

StefanRijnhart left a comment •

edited

Loading