Skip to content

fix(jump-to-label-map): Use undefined for viewportId for arrow navigation.#5774

Merged
jbocce merged 4 commits intoOHIF:masterfrom
jbocce:fix/OHIF-2462-jump-to-label-map
Feb 4, 2026
Merged

fix(jump-to-label-map): Use undefined for viewportId for arrow navigation.#5774
jbocce merged 4 commits intoOHIF:masterfrom
jbocce:fix/OHIF-2462-jump-to-label-map

Conversation

@jbocce
Copy link
Collaborator

@jbocce jbocce commented Feb 3, 2026

Context

See #5771

Changes & Results

See CS3D PR: cornerstonejs/cornerstone3D#2592
Use undefined for viewportId for arrow navigation.

Testing

See #5771

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 6.49 GB / 31.68 GB
Binaries:
Node: 23.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.9.2 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 144.0.7559.110

@netlify
Copy link

netlify bot commented Feb 3, 2026

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 06bea8c
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6983742a128ca53d4f193450
😎 Deploy Preview https://deploy-preview-5774--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jbocce jbocce marked this pull request as ready for review February 4, 2026 15:46
@aimee-ferreira
Copy link
Collaborator

Verification has passed - jump arrows and clicking the segment now jump to the correct segment. No new defects were logged.

@jbocce jbocce merged commit 512aa3b into OHIF:master Feb 4, 2026
6 of 7 checks passed
@jbocce jbocce deleted the fix/OHIF-2462-jump-to-label-map branch February 4, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants