fix(jump-to-label-map): Handle case in getReferenceVolumeForSegmentationVolume where the volume is built from the segmentation's image IDs.#2592
Merged
wayfarer3130 merged 3 commits intocornerstonejs:mainfrom Feb 4, 2026
Conversation
…ionVolume where the volume is built from the segmentation's image IDs. In VolumeViewport.jumpToWorld, do not jump to the world position if it is outside the bounds of the volume.
3 tasks
wayfarer3130
approved these changes
Feb 3, 2026
Collaborator
wayfarer3130
left a comment
There was a problem hiding this comment.
Could you just update the comment?
Otherwise I understand what you are doing - we need a better way to ask the question about getting volumes - could you test with stack viewports to make sure it works there?
wayfarer3130
requested changes
Feb 3, 2026
Collaborator
wayfarer3130
left a comment
There was a problem hiding this comment.
Actually, I'd like to test a few things as to how they work.
Collaborator
Author
Yup. NP. |
wayfarer3130
approved these changes
Feb 4, 2026
Collaborator
wayfarer3130
left a comment
There was a problem hiding this comment.
Tested a number of scenarios. Although I can cause it to jump to something not visible, that is a separate issue not affected by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
See OHIF issue OHIF/Viewers#5771
Changes & Results
Handle case in
getReferenceVolumeForSegmentationVolumewhere the volume is built from the segmentation's image IDs.In
VolumeViewport.jumpToWorld, do not jump to the world position if it is outside the bounds of the volume.The full fix in OHIF requires both this PR and OHIF PR OHIF/Viewers#5774
Testing
See OHIF issue OHIF/Viewers#5771
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 6.49 GB / 31.68 GB
Binaries:
Node: 23.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.9.2 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 144.0.7559.110