Skip to content

fix(jump-to-label-map): Handle case in getReferenceVolumeForSegmentationVolume where the volume is built from the segmentation's image IDs.#2592

Merged
wayfarer3130 merged 3 commits intocornerstonejs:mainfrom
jbocce:fix/OHIF-2462-jump-to-label-map
Feb 4, 2026
Merged

fix(jump-to-label-map): Handle case in getReferenceVolumeForSegmentationVolume where the volume is built from the segmentation's image IDs.#2592
wayfarer3130 merged 3 commits intocornerstonejs:mainfrom
jbocce:fix/OHIF-2462-jump-to-label-map

Conversation

@jbocce
Copy link
Collaborator

@jbocce jbocce commented Feb 3, 2026

Context

See OHIF issue OHIF/Viewers#5771

Changes & Results

Handle case in getReferenceVolumeForSegmentationVolume where the volume is built from the segmentation's image IDs.
In VolumeViewport.jumpToWorld, do not jump to the world position if it is outside the bounds of the volume.

The full fix in OHIF requires both this PR and OHIF PR OHIF/Viewers#5774

Testing

See OHIF issue OHIF/Viewers#5771

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 6.49 GB / 31.68 GB
Binaries:
Node: 23.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.9.2 - C:\Users\joebo\AppData\Local\fnm_multishells\14076_1770140411794\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 144.0.7559.110

…ionVolume where the volume is built from the segmentation's image IDs.

In VolumeViewport.jumpToWorld, do not jump to the world position if it is outside the bounds of the volume.
Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just update the comment?
Otherwise I understand what you are doing - we need a better way to ask the question about getting volumes - could you test with stack viewports to make sure it works there?

Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'd like to test a few things as to how they work.

@jbocce jbocce requested a review from wayfarer3130 February 3, 2026 20:18
@jbocce
Copy link
Collaborator Author

jbocce commented Feb 3, 2026

Actually, I'd like to test a few things as to how they work.

Yup. NP.

Copy link
Collaborator

@wayfarer3130 wayfarer3130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a number of scenarios. Although I can cause it to jump to something not visible, that is a separate issue not affected by this PR.

@wayfarer3130 wayfarer3130 merged commit 753e212 into cornerstonejs:main Feb 4, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants