Skip to content

Validate test binaries upon code changes#780

Open
elizabethteng wants to merge 101 commits intov2.3from
et-validation
Open

Validate test binaries upon code changes#780
elizabethteng wants to merge 101 commits intov2.3from
et-validation

Conversation

@elizabethteng
Copy link
Contributor

@elizabethteng elizabethteng commented Dec 18, 2025

  • enhance 1Z_sun_binaries_suite.py to save evolution data to h5 file in ./outputs
  • update evolve_binaries.sh to reflect output saving
  • write validate_binaries.sh (script for single-line command for comparing branches)
    • call evolve_binaries.sh for new branch
    • call compare_runs.py and save output to file in ./outputs for difference report
    • give option to compare two branches and evolve both, or compare new branch to passed h5 file
  • extract data from runs and save to file
  • write compare_runs.py (compares two h5 files and reports differences)
    • outline
    • quantitative differences beyond thresholds
    • qualitative differences to evolution
    • differences to warnings and errors
  • generate baseline.h5
  • extend to other metallicities
  • tweaks suggested during Mar 12 meeting (They are in your physical notebook!!)

@elizabethteng elizabethteng changed the title Create validate_binaries.sh Validate test binaries upon code changes Dec 18, 2025
@elizabethteng elizabethteng marked this pull request as ready for review March 9, 2026 23:20
@sgossage
Copy link
Contributor

sgossage commented Mar 19, 2026

@elizabethteng , during a dev meeting we saw that there were some differences between values when comparing two branches according to these tests. I'm planning to help by looking into the source of those differences. Can you please post here which two branches produced those differences if you have them on hand?

@sgossage sgossage requested review from a team March 19, 2026 19:43
@sgossage sgossage added enhancement New feature or request labels Mar 19, 2026
@sgossage sgossage modified the milestone: v2.3 Mar 19, 2026
@sgossage sgossage requested review from sgossage March 19, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants