Avoid actually setting unlimited value in policy #1689
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bording
force-pushed
the
delivery-limit
branch
from
1b44924 to
c7f2820
Compare
bording
force-pushed
the
delivery-limit
branch
from
c7f2820 to
99ef9f5
Compare
boblangley
approved these changes
Nov 21, 2025
| } | ||
|
|
||
| public const int UnlimitedDeliveryLimitIndicatorValue = -1_000; | ||
| public const int BigValueInsteadOfActuallyUnlimited = 100_000; |
Member
There was a problem hiding this comment.
I know we are trying to be as limited as possible since this is a "bug" fix, however, should we consider letting the user configure this? I can see an argument for not doing so, in that NSB should never reach this number of retries. This number being a "problem" presupposes a bug in RabbitMQ transport or NServiceBus core, or misconfigured recoverability settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.