Skip to content

Conversation

@kineticsystem
Copy link

Issue

https://github.com/PickNikRobotics/moveit_pro/issues/13061

Description

I fixed the following warnings

--- stderr: kinova_vision                                                                             
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp: In member function ‘bool ros_kortex_vision::Vision::start()’:
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:266:14: warning: enumeration value ‘GST_STATE_CHANGE_SUCCESS’ not handled in switch [-Wswitch]
  266 |       switch (ret)
      |              ^
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:266:14: warning: enumeration value ‘GST_STATE_CHANGE_NO_PREROLL’ not handled in switch [-Wswitch]
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp: In member function ‘bool ros_kortex_vision::Vision::publish()’:
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:383:24: warning: comparison of integer expressions of different signedness: ‘sensor_msgs::msg::CameraInfo_<std::allocator<void> >::_height_type’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
  383 |   if (cur_cinfo.height != image_height_ || cur_cinfo.width != image_width_)
      |       ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:383:60: warning: comparison of integer expressions of different signedness: ‘sensor_msgs::msg::CameraInfo_<std::allocator<void> >::_width_type’ {aka ‘unsigned int’} and ‘int’ [-Wsign-compare]
  383 |   if (cur_cinfo.height != image_height_ || cur_cinfo.width != image_width_)
      |                                            ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp: In member function ‘bool ros_kortex_vision::Vision::start()’:
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:276:5: warning: this statement may fall through [-Wimplicit-fallthrough=]
  276 |     }
      |     ^
/home/parallels/user_ws/src/external_dependencies/ros2_kortex_vision/src/vision.cpp:278:5: note: here
  278 |     case GST_STATE_CHANGE_SUCCESS:
      |     ^~~~
---

@kineticsystem kineticsystem self-assigned this Jun 20, 2025
@kineticsystem kineticsystem marked this pull request as ready for review June 20, 2025 16:46
@griswaldbrooks griswaldbrooks merged commit d9050d2 into ros2 Jun 20, 2025
1 check passed
@kineticsystem kineticsystem deleted the pr-fix-warnings branch June 20, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants