Skip to content

Fixed compile warnings. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
griswaldbrooks merged 1 commit into from
Jun 20, 2025
Merged

Fixed compile warnings. #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/vision.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,24 @@ bool Vision::start()
RCLCPP_ERROR(node_->get_logger(), "[%s]: Failed to start stream", camera_name_.c_str());
return false;

case GST_STATE_CHANGE_NO_PREROLL:
RCLCPP_INFO(node_->get_logger(), "[%s]: Stream started (no preroll)", camera_name_.c_str());
break;

case GST_STATE_CHANGE_ASYNC:
RCLCPP_ERROR(node_->get_logger(), "[%s]: Failed to start stream (timeout)", camera_name_.c_str());
return false;

case GST_STATE_CHANGE_SUCCESS:
RCLCPP_INFO(node_->get_logger(), "[%s]: Stream started (async)", camera_name_.c_str());
break;

default:
RCLCPP_ERROR(node_->get_logger(), "[%s]: Unknown state change result", camera_name_.c_str());
return false;
}

break;
}

case GST_STATE_CHANGE_SUCCESS:
Expand Down Expand Up @@ -380,7 +394,7 @@ bool Vision::publish()
// Update header information
auto cur_cinfo = camera_info_manager_->getCameraInfo();

if (cur_cinfo.height != image_height_ || cur_cinfo.width != image_width_)
if (static_cast<int>(cur_cinfo.height) != image_height_ || static_cast<int>(cur_cinfo.width) != image_width_)
{
RCLCPP_WARN_ONCE(node_->get_logger(),
"[%s]: Calibration file sensor resolution (%dx%d pixels) doesn't match stream resolution (%dx%d "
Expand Down