Fix NotImplementedError usage in Projector#367
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #367 +/- ##
==========================================
+ Coverage 84.00% 84.26% +0.26%
==========================================
Files 194 194
Lines 10018 10025 +7
Branches 1055 1055
==========================================
+ Hits 8416 8448 +32
+ Misses 1308 1281 -27
- Partials 294 296 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the usage of NotImplementedError in Projector.transform and adds a regression test to ensure the proper exception is raised.
- Corrected the behavior in Projector.transform to raise NotImplementedError.
- Added a regression test to verify the correct exception behavior.
- Updated the changelog to reflect these changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/core/test_projectors.py | Added regression test to verify NotImplementedError is raised in Projector. |
| policyengine_core/projectors/projector.py | Updated transform to properly raise NotImplementedError. |
| changelog_entry.yaml | Added changelog entry summarizing this patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Projector.transformTesting
pytest tests/core/test_projectors.py::test_base_projector_transform_raises -q