Skip to content

Fix NotImplementedError usage in Projector#367

Merged
MaxGhenis merged 2 commits intomasterfrom
lbdrfo-codex/find-simple-improvements
Jul 24, 2025
Merged

Fix NotImplementedError usage in Projector#367
MaxGhenis merged 2 commits intomasterfrom
lbdrfo-codex/find-simple-improvements

Conversation

@MaxGhenis
Copy link
Copy Markdown
Contributor

Summary

  • fix NotImplementedError usage in Projector.transform
  • add regression test for Projector base class

Testing

  • pytest tests/core/test_projectors.py::test_base_projector_transform_raises -q

@codecov
Copy link
Copy Markdown

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (30facf3) to head (cbd1394).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   84.00%   84.26%   +0.26%     
==========================================
  Files         194      194              
  Lines       10018    10025       +7     
  Branches     1055     1055              
==========================================
+ Hits         8416     8448      +32     
+ Misses       1308     1281      -27     
- Partials      294      296       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the usage of NotImplementedError in Projector.transform and adds a regression test to ensure the proper exception is raised.

  • Corrected the behavior in Projector.transform to raise NotImplementedError.
  • Added a regression test to verify the correct exception behavior.
  • Updated the changelog to reflect these changes.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/core/test_projectors.py Added regression test to verify NotImplementedError is raised in Projector.
policyengine_core/projectors/projector.py Updated transform to properly raise NotImplementedError.
changelog_entry.yaml Added changelog entry summarizing this patch.

@MaxGhenis MaxGhenis merged commit f5574aa into master Jul 24, 2025
4 checks passed
@MaxGhenis MaxGhenis deleted the lbdrfo-codex/find-simple-improvements branch July 24, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants