Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog_entry.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
- bump: patch
changes:
fixed:
- Projector.transform now raises NotImplementedError
added:
- regression test ensuring base Projector.transform raises
2 changes: 1 addition & 1 deletion policyengine_core/projectors/projector.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,4 @@ def transform_and_bubble_up(self, result):
return self.parent.transform_and_bubble_up(transformed_result)

def transform(self, result: ArrayLike):
return NotImplementedError()
raise NotImplementedError()
10 changes: 10 additions & 0 deletions tests/core/test_projectors.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
import numpy as np
import pytest

from policyengine_core.entities import build_entity
from policyengine_core.model_api import ETERNITY, Enum, Variable
from policyengine_core.simulations.simulation_builder import SimulationBuilder

from policyengine_core.taxbenefitsystems import TaxBenefitSystem


def test_base_projector_transform_raises():
from policyengine_core.projectors.projector import Projector

projector = Projector()
with pytest.raises(NotImplementedError):
projector.transform([])


def test_shortcut_to_containing_entity_provided():
"""
Tests that, when an entity provides a containing entity,
Expand Down