Fixing a test that was failing the first time it was executed, because it didn't set a class variable before testing its value #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryVariable and ArgumentVariable
updating ASTInterpreter and ASTPostOrderTreeVisitor according to new AST visitor API
…cy to the baseline
removing deprecated spec-debugger dependency + adding espell dependen…
…the class variable before accessing it
…th DAST is well tested
Contributor
Author
|
Only the last two commits are significant |
Contributor
Author
|
Other failurse will be fixed in different PRs (see other issues) |
Contributor
Author
|
The failure I will investigate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30
Another test would then set the class variable to the expected value. That's why the test was green after the first time