Skip to content

Fixing a test that was failing the first time it was executed, because it didn't set a class variable before testing its value #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adri09070 wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixing a test that was failing the first time it was executed, because it didn't set a class variable before testing its value #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6b4de4b
updating ASTInterpreter and visitors according to nez API for Tempora…
adri09070 Aug 18, 2022
474dbd3
updating ASTInterpreter and ASTPostOrderTreeVisitor according to new …
adri09070 Aug 30, 2022
cae98fc
Merge pull request #1 from adri09070/Pharo11
adri09070 Sep 6, 2022
91d5689
removing deprecated spec-debugger dependency + adding espell dependen…
adri09070 Sep 6, 2022
a6aed4d
Merge pull request #2 from adri09070/fixing-baseline-dependencies
adri09070 Sep 9, 2022
0d010c7
Merge 34491bb2ac9f3c256eb734f8856e61c0ca1a9297
adri09070 Sep 23, 2022
21444f5
synch with RMODINRIA/DebuggableASTInterpreter
adri09070 Sep 23, 2022
4c062f5
Merge 9b23f619a341745a94a7a52fbf39633d7190862e
adri09070 Sep 26, 2022
fc04a52
fixing #testGetClassVariableFromMethodInInstanceSide that didn't set …
adri09070 Jun 15, 2023
f779b68
setting class variable to nil in a test, to ensure that the setter wi…
adri09070 Jun 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions DebuggableASTInterpreter/DASTInterpreter.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,14 @@ DASTInterpreter >> visitLiteralVariableNode: aRBVariableNode [
^ self visitGlobalNode: aRBVariableNode
]

{ #category : #visiting }
DASTInterpreter >> visitLocalVariableNode: aNode [

"call visitTemporaryNode: for backward compatibility"

^ self visitTemporaryNode: aNode
]

{ #category : #visiting }
DASTInterpreter >> visitMessageNode: aRBMessageNode [
| arguments receiver method newContext |
Expand Down
5 changes: 5 additions & 0 deletions DebuggableASTInterpreter/DASTInterpreterClassForTests3.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,3 +38,8 @@ DASTInterpreterClassForTests3 >> initialize [
DASTInterpreterClassForTests3 >> setClassVariable [
classVar := 42
]

{ #category : #initialization }
DASTInterpreterClassForTests3 >> setClassVariableToNil [
classVar := nil
]
17 changes: 12 additions & 5 deletions DebuggableASTInterpreter/DASTInterpreterTests.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,13 @@ DASTInterpreterTests >> testFalse [

{ #category : #'tests-variables-class' }
DASTInterpreterTests >> testGetClassVariableFromMethodInInstanceSide [
self assert: (self evaluateProgram: 'DASTInterpreterClassForTests3 new getClassVariable' )
equals: 42

| value |
value := DASTInterpreterClassForTests3 new getClassVariable.
self
assert: (self evaluateProgram:
'DASTInterpreterClassForTests3 new getClassVariable')
equals: value


]
Expand Down Expand Up @@ -773,10 +778,12 @@ DASTInterpreterTests >> testSendMessageToBlock [
{ #category : #'tests-variables-class' }
DASTInterpreterTests >> testSetAndGetClassVariableFromMethodInInstanceSide [
"ToDo: reimplement when the environment contains representation of objects"
self assert: (self evaluateProgram: 'DASTInterpreterClassForTests3 new setClassVariable. DASTInterpreterClassForTests3 new getClassVariable' )
equals: 42


DASTInterpreterClassForTests3 new setClassVariableToNil.
self
assert: (self evaluateProgram:
'DASTInterpreterClassForTests3 new setClassVariable. DASTInterpreterClassForTests3 new getClassVariable')
equals: 42
]

{ #category : #'tests-variables-class' }
Expand Down
12 changes: 10 additions & 2 deletions DebuggableASTInterpreter/DASTPostOrderTreeVisitor.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ DASTPostOrderTreeVisitor >> visitArgumentNode: aRBArgumentNode [
]

{ #category : #visiting }
DASTPostOrderTreeVisitor >> visitArgumentVariableNode: aRBVariableNode [
DASTPostOrderTreeVisitor >> visitArgumentVariableNode: aRBVariableNode [

^ self visitTemporaryNode: aRBVariableNode
]
Expand Down Expand Up @@ -113,6 +113,14 @@ DASTPostOrderTreeVisitor >> visitLiteralVariableNode: aRBVariableNode [
^ self visitGlobalNode: aRBVariableNode
]

{ #category : #visiting }
DASTPostOrderTreeVisitor >> visitLocalVariableNode: aNode [

"call visitTemporaryNode: for backward compatibility"

^ self visitTemporaryNode: aNode
]

{ #category : #visiting }
DASTPostOrderTreeVisitor >> visitMessageNode: aRBMessageNode [

Expand Down Expand Up @@ -157,7 +165,7 @@ DASTPostOrderTreeVisitor >> visitSuperNode: aRBSuperNode [
^ stack push: aRBSuperNode
]

{ #category : #'as yet unclassified' }
{ #category : #visiting }
DASTPostOrderTreeVisitor >> visitTemporaryNode: aRBTemporaryNode [
stack push: aRBTemporaryNode
]
Expand Down