CsvSpawner: dependencies update#172
Merged
jhanca-robotecai merged 3 commits intoo3de-2505from Mar 4, 2026
Merged
Conversation
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
Signed-off-by: Piotr Jaroszek <piotr.jaroszek@robotec.ai>
jhanca-robotecai
requested changes
Mar 3, 2026
Collaborator
There was a problem hiding this comment.
I would prefer to fix the cause not the symptom.
This Gem does not use ROS 2 at all. I see no reason to link it to Gem::ROS2.Static. This might be the reason the issue with fastcdr is not reproduced with this Gem.
Please see #173
5 tasks
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
pijaro
changed the title
Contributor
Author
|
@jhanca-robotecai Yup, makes more sense. Merged your changes and we are good to go. |
jhanca-robotecai
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There were some changes in ROS 2 linking and dependency resolving, so we need to explicitly add the rclcpp dependency to our gem.
Committer Checklist
Please confirm the following before marking this PR as ready for review: