Skip to content

[2605] Fix build and remove obsolete files#180

Merged
jhanca-robotecai merged 4 commits intoo3de-2605from
mp/scripts/2605
Mar 25, 2026
Merged

[2605] Fix build and remove obsolete files#180
jhanca-robotecai merged 4 commits intoo3de-2605from
mp/scripts/2605

Conversation

@michalpelka
Copy link
Copy Markdown
Collaborator

@michalpelka michalpelka commented Mar 23, 2026

Part of update effort of the Roscon demo 2023 to Jazzy/2605.

What does this PR do?

Please describe the purpose and scope of this PR. For a bug fix, what was the old behavior, and what is the new behavior? If it's a new feature, explain what it adds and why.

Include links to any related issues, RFCs, tickets, or documentation.


How was this PR tested?

Describe any manual or automated testing performed. Include tools used (e.g., pytest, Postman), scenarios tested, and environments used (dev/main).


Screenshots / Logs / Supporting Evidence (if applicable)

Add screenshots, terminal logs, or relevant links to builds/tests as needed.


Committer Checklist

Please confirm the following before marking this PR as ready for review:

  • Code changes are well-documented
  • Tests have been added or updated
  • Code owners file and CI config were updated if new Gem was added
  • The code is formatted according to the project's style guide
  • The version number has been updated according to the contributing guidelines

@michalpelka michalpelka changed the title mp/scripttools/2605 Update script tools to 2605 Mar 23, 2026
@jhanca-robotecai
Copy link
Copy Markdown
Collaborator

How does it compare against #176 ? It looks like a duplicated effort.

michalpelka and others added 2 commits March 24, 2026 15:51
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
@jhanca-robotecai jhanca-robotecai changed the title Update script tools to 2605 [2605] Fix build and remove obsolete files Mar 24, 2026
@jhanca-robotecai
Copy link
Copy Markdown
Collaborator

I rebased the code on top of #176 and went a bit further in cleaning the code:

  • removed includes that were not used
  • removed two system components that were not used
  • bumped Gem version
  • marked Gem as compatible with 2605

Tested on:
o3de: 5005ef02d9
o3de-extras: faacbbe0

Copy link
Copy Markdown
Collaborator

@jhanca-robotecai jhanca-robotecai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after my own changes; it would make sense if someone else checks this out.

Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
@jhanca-robotecai jhanca-robotecai merged commit 928d1e2 into o3de-2605 Mar 25, 2026
1 check passed
@jhanca-robotecai jhanca-robotecai deleted the mp/scripts/2605 branch March 25, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants