[2605] Fix build and remove obsolete files#180
Merged
jhanca-robotecai merged 4 commits intoo3de-2605from Mar 25, 2026
Merged
Conversation
Collaborator
|
How does it compare against #176 ? It looks like a duplicated effort. |
Signed-off-by: Michał Pełka <michal.pelka@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
4811db4 to
5aae09b
Compare
Collaborator
|
I rebased the code on top of #176 and went a bit further in cleaning the code:
Tested on: |
jhanca-robotecai
approved these changes
Mar 24, 2026
Collaborator
jhanca-robotecai
left a comment
There was a problem hiding this comment.
Approved after my own changes; it would make sense if someone else checks this out.
patrykantosz
approved these changes
Mar 25, 2026
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of update effort of the Roscon demo 2023 to Jazzy/2605.
What does this PR do?
Please describe the purpose and scope of this PR. For a bug fix, what was the old behavior, and what is the new behavior? If it's a new feature, explain what it adds and why.
Include links to any related issues, RFCs, tickets, or documentation.
How was this PR tested?
Describe any manual or automated testing performed. Include tools used (e.g., pytest, Postman), scenarios tested, and environments used (dev/main).
Screenshots / Logs / Supporting Evidence (if applicable)
Add screenshots, terminal logs, or relevant links to builds/tests as needed.
Committer Checklist
Please confirm the following before marking this PR as ready for review: