Fix: Tool Tips positioned above for Message Toolbox#901
Fix: Tool Tips positioned above for Message Toolbox#901KrishnaShuk wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
Hello @KrishnaShuk, the tooltip arrow should point to the message toolbox, not the icon inside. If you want to change the position from bottom to top, please consider this point as well: Observe the current tooltip position, it's not directly on the icon. |
|
Will lift up the tooltip arrow that will point to the message toolbox. @dhairyashiil thanks for suggestion. |
Well, I have an idea. Instead of changing the position of the tooltip from bottom to top, you can change the positioning of the message toolbox by shifting it upwards. However, there's a catch: the message toolbar positioning differs for normal messages and quoted messages, so you need to ensure that the toolbar is usable for both types of messages. |
2ef2985 to
8f3bb40
Compare
|
If you shift it to top, then the problem will again be the same when a message is at the top i believe, can we make it dynamic ? |
|
You are right @Spiral-Memory , will try to make it more dynamic. |
Tool-Tips positioned above Message Toolbox
Acceptance Criteria fulfillment
Fixes #900
Video/Screenshots
Screencast.from.2025-01-15.15-20-10.webm
Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr- 901 after approval.