Improve performance of find_by_iso_numeric method #1147
Merged
+66
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pranavbabu
commented
Jul 18, 2025
pranavbabu
commented
ruby 3.3.3 (2024-06-12 revision f1c7b6f435) [arm64-darwin23] Warming up -------------------------------------- Before optimization 2.135k i/100ms After optimization 55.681k i/100ms Calculating ------------------------------------- Before optimization 21.148k (± 0.8%) i/s (47.29 μs/i) - 106.750k in 5.048173s After optimization 549.315k (± 0.6%) i/s (1.82 μs/i) - 2.784M in 5.068425s Comparison: After optimization: 549314.7 i/s Before optimization: 21147.5 i/s - 25.98x slower
Member
|
Hi there @pranavbabu! Any idea when you can get to address the review comment? 🙏🏻 |
Contributor
Author
|
@sunny Hi! Thanks for reminding me, currently a bit overloaded on work, but I will definitely will look into that and another issue where you pinged me ;) I'm looking forward for all the changes that have been made to be released we rely on this gem a lot! |
Member
|
No worries, thank you for your answer! Keeping this open for the time being then 👍🏻 |
Contributor
Author
check it out ;) |
sunny
previously approved these changes
Dec 1, 2025
Member
sunny
left a comment
sunny
left a comment
There was a problem hiding this comment.
Looking good ✨
Can you add an entry to the CHANGELOG as well? 🙏🏻
sunny
approved these changes
Dec 4, 2025
This was referenced Dec 5, 2025
Closed
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.