[4.0] add bigdecimal to gemspec for ruby 3.4#1882
Closed
mathbruyen wants to merge 1 commit intoShopify:4-0-stablefrom
Closed
[4.0] add bigdecimal to gemspec for ruby 3.4#1882mathbruyen wants to merge 1 commit intoShopify:4-0-stablefrom
mathbruyen wants to merge 1 commit intoShopify:4-0-stablefrom
Conversation
Contributor
|
Hello @mathbruyen 👋 Since the Liquid version 4 releases are 3+ years old, we should try to use the latest version of Liquid. It looks like there is already PR to update Jekyll's Liquid version: |
Author
|
Jekyll won't include required dependencies for Ruby 3.4 as a patch release (comment), support will thus land in another major which will (likely) use a more recent version of liquid. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bigdecimalwas removed from stdlib in Ruby 3.4 and liquid fails to be loaded:Fixes #1772 which also mentions
base64, but the later is not directly used by liquid thus not added.Similar pull request but targeted at main which already has the change (
5.xreleases have the depenency), can likely be closed: #1779