Skip to content

Backport #9522 for v4.3.x: Add csv to runtime dependency list#9736

Closed
mathbruyen wants to merge 1 commit intojekyll:4.3-stablefrom
mathbruyen:ruby-3.4-csv-backport
Closed

Backport #9522 for v4.3.x: Add csv to runtime dependency list#9736
mathbruyen wants to merge 1 commit intojekyll:4.3-stablefrom
mathbruyen:ruby-3.4-csv-backport

Conversation

@mathbruyen
Copy link
Contributor

@mathbruyen mathbruyen commented Dec 27, 2024

This backports 25fd87c to 4.3-stable

Context

Jekyll 4.3.4 fails to run on ruby 3.4 because csv dependency was removed from stdlib. Cherry-picked #9522 into 4.3-stable.

This is not sufficient to get Jekyll to work on 3.4, liquid requires bigdecimal and safe_yaml requires base64. safe_yaml has not been released in the last 5 years, I don't know if it is still maintained. If not maybe SafeYAML.load can be replaced by YAML.safe_load.

@ashmaroli ashmaroli added the ⏪ backport Changes will be merged into an older stable branch label Dec 27, 2024
@ashmaroli ashmaroli changed the title [4.3] add csv to runtime dependency list Backport #9522 for v4.3.x: Add csv to runtime dependency list Dec 27, 2024
@ashmaroli
Copy link
Member

Hello @mathbruyen
Thanks for submitting this pull request.

The 4.3-stable branch needs to have its CI updated to test against Ruby 3.4 as well, which is currently waiting on RubyInstaller for shipping a build (for testing on Windows).

Once the relevant changes are backported from master, this branch may be updated (via a git pull <...> call (preferred over git rebase <...>)).

@CookiePLMonster
Copy link
Contributor

Fixes #9741.

@cocallaw
Copy link

cocallaw commented Jan 7, 2025

Hello @ashmaroli any update on when the this will be resolved ?

@ashmaroli
Copy link
Member

@cocallaw, I'm currently waiting for gem 'cucumber' (a development dependency) to ship a Ruby 3.4-compatible version.

@fernandopasik
Copy link

Yeah, this is the pr for the cucumber package cucumber/cucumber-ruby#1771

@ashmaroli
Copy link
Member

Actually, the concerned pull request is cucumber/cucumber-ruby#1773

@ashmaroli
Copy link
Member

Apologies, everyone! Introducing a runtime dependency is beyond the scope of a patch release. Therefore, this change won't be released as v4.3.x

@ashmaroli ashmaroli closed this Jan 16, 2025
@jekyll jekyll locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age ⏪ backport Changes will be merged into an older stable branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants