Add integrity check for owner relationships#592
Merged
Conversation
Member
Author
38141a5 to
e688ae1
Compare
st0012
reviewed
Feb 24, 2026
Morriar
reviewed
Feb 26, 2026
e688ae1 to
bb35710
Compare
4c602d8 to
4d2f41e
Compare
c7c5135 to
8d0687a
Compare
4d2f41e to
5666886
Compare
Base automatically changed from
01-12-remove_temporary_constant_skips_in_resolution
to
main
February 27, 2026 20:42
st0012
reviewed
Feb 27, 2026
8d0687a to
5496a9d
Compare
This was referenced Mar 2, 2026
5496a9d to
f0e9c0a
Compare
9431446 to
8f9a3c1
Compare
f0e9c0a to
298bde0
Compare
st0012
approved these changes
Mar 2, 2026
Member
st0012
left a comment
There was a problem hiding this comment.
We should rename error.rb as well. Otherwise looks good
8f9a3c1 to
2d6e58d
Compare
298bde0 to
9989cff
Compare
2d6e58d to
aecab13
Compare
9989cff to
8790ac3
Compare
aecab13 to
383aa1e
Compare
8790ac3 to
6863542
Compare
alexcrocha
approved these changes
Mar 4, 2026
da688ab to
25ac4f0
Compare
6863542 to
eb1ad09
Compare
eb1ad09 to
710ee51
Compare
710ee51 to
520bf5c
Compare
520bf5c to
e2b9d62
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note: this PR starts running resolution on our top 100 gems check, which fails until #505 is shipped.
This PR adds an integrity check back, so that we can perform more expensive validation of the graph to catch bugs early.
This first iteration only validates ownership relations. The implemented rules are:
ObjectandBasicObjectcan own themselvesI exposed this API to Ruby, so that we can start running it against the top 100 gems.