Conversation
Member
Author
This was referenced Mar 2, 2026
0d5c6f8 to
4f2c3c2
Compare
5414794 to
cc10553
Compare
9cf59ac to
5ea4e22
Compare
cc10553 to
14702a0
Compare
alexcrocha
approved these changes
Mar 4, 2026
14702a0 to
775ee22
Compare
5ea4e22 to
6517163
Compare
775ee22 to
517c495
Compare
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Another case we need promotion found in the wild. We need to be able to handle auto-promotion in this case:
Since
Foois already mark as promotable, we need to promote it to a namespace so thatFoo::Barcan work as expected.Note that we assume a module for now. This approach is not 100% correct, but we can't get much more precise without a type system first.