Removed announcementBar feature flag

[EvanHahn]

ref f9f5f72

This change should have no user impact.

The announcementBar feature flag has been enabled since 2023. We can remove the flag and assume it's always on.

---

Note

Low Risk
Small flag-removal change that mainly deletes gating and updates tests; risk is limited to unintentionally exposing /api/announcement where it was previously blocked by misconfiguration.

Overview
Removes the announcementBar labs feature flag from the admin feature service and from shared labs GA flag handling.

The members /api/announcement route is no longer protected by labs.enabledMiddleware('announcementBar'), and related test fixtures/snapshots are updated to stop expecting or setting the flag in config/labs payloads.

^{Written by Cursor Bugbot for commit f615015. This will update automatically on new commits. Configure here.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 26aa2e2 and 8b65db5.

📒 Files selected for processing (1)

• apps/admin-x-framework/src/test/acceptance.ts

💤 Files with no reviewable changes (1)

• apps/admin-x-framework/src/test/acceptance.ts

---

Walkthrough

Removed the announcementBar feature flag from multiple initialization and exposure points: test fixtures (defaultLabFlags), the public FeatureService declaration, the members route middleware guard (labs.enabledMiddleware('announcementBar')), and the core GA_FEATURES list; no other functional changes were made.

Possibly related PRs

• Removed themeErrorsNotification lab flag #26088 — Performs the same code-level refactor pattern (removing a lab flag from defaults and GA_FEATURES) for a different flag (themeErrorsNotification), indicating a closely related change in feature-flag handling.

Suggested reviewers

• troyciesco

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: removal of the announcementBar feature flag.
Description check	✅ Passed	The description is directly related to the changeset, explaining the rationale, scope, and impact of removing the announcementBar feature flag.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch announcementBar-flag-begone

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.15%. Comparing base (62529af) to head (8b65db5).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #26196   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files        1529     1528    -1     
  Lines      120229   120172   -57     
  Branches    14526    14524    -2     
=======================================
- Hits        87953    87912   -41     
+ Misses      31272    31241   -31     
- Partials     1004     1019   +15     

Flag	Coverage Δ
admin-tests	53.77% <ø> (+0.01%)	⬆️
e2e-tests	73.15% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[troyciesco]

lgtm, though i did discover through reviewing this that we have a specific reference to announcementBar in labs.test.js.

there were a couple tests in that file that were flaky in that way, so i cleaned them up and added you as a reviewer here in case there was something better/different you came across or something: #26622

i think technically we should merge that test change first but it's not a huge deal.