Skip to content

Removed announcementBar feature flag #26196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvanHahn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed announcementBar feature flag #26196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/admin-x-framework/src/test/acceptance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ export const responseFixtures = {
const defaultLabFlags = {
collections: false,
outboundLinkTagging: false,
announcementBar: false,
members: false
};

Expand Down
1 change: 0 additions & 1 deletion ghost/admin/app/services/feature.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ export default class FeatureService extends Service {
// labs flags
@feature('stripeAutomaticTax') stripeAutomaticTax;
@feature('emailCustomization') emailCustomization;
@feature('announcementBar') announcementBar;
@feature('importMemberTier') importMemberTier;
@feature('lexicalIndicators') lexicalIndicators;
@feature('editorExcerpt') editorExcerpt;
Expand Down
2 changes: 0 additions & 2 deletions ghost/core/core/server/web/members/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const membersService = require('../../services/members');
const stripeService = require('../../services/stripe');
const middleware = membersService.middleware;
const shared = require('../shared');
const labs = require('../../../shared/labs');
const errorHandler = require('@tryghost/mw-error-handler');
const config = require('../../../shared/config');
const {http} = require('@tryghost/api-framework');
Expand Down Expand Up @@ -132,7 +131,6 @@ module.exports = function setupMembersApp() {
// Announcement
membersApp.use(
'/api/announcement',
labs.enabledMiddleware('announcementBar'),
middleware.loadMemberSession,
announcementRouter()
);
Expand Down
1 change: 0 additions & 1 deletion ghost/core/core/shared/labs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const messages = {

// flags in this list always return `true`, allows quick global enable prior to full flag removal
const GA_FEATURES = [
'announcementBar',
'customFonts',
'explore',
'commentModeration',
Expand Down
1 change: 0 additions & 1 deletion ghost/core/test/e2e-api/admin/__snapshots__/config.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ Object {
"environment": StringMatching /\\^testing/,
"labs": Object {
"additionalPaymentMethods": true,
"announcementBar": true,
"commentModeration": true,
"customFonts": true,
"editorExcerpt": true,
Expand Down
2 changes: 1 addition & 1 deletion ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,7 +1675,7 @@ exports[`Settings API Edit can edit Stripe settings when Stripe Connect limit is
Object {
"access-control-allow-origin": "http://127.0.0.1:2369",
"cache-control": "no-cache, private, no-store, must-revalidate, max-stale=0, post-check=0, pre-check=0",
"content-length": "5148",
"content-length": "5123",
"content-type": "application/json; charset=utf-8",
"content-version": StringMatching /v\\\\d\\+\\\\\\.\\\\d\\+/,
"etag": StringMatching /\\(\\?:W\\\\/\\)\\?"\\(\\?:\\[ !#-\\\\x7E\\\\x80-\\\\xFF\\]\\*\\|\\\\r\\\\n\\[\\\\t \\]\\|\\\\\\\\\\.\\)\\*"/,
Expand Down