Plugin migration #4927
Draft
Plugin migration #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make `electronService` silently fail * Remove `process.env` check * Load settings from Octoprint settings
Just rely on cookie auth for now
Need to figure out what's up with this
Remove dead electron code Add type for config API response
Need to ensure endpoint is properly locked down
Streamlines the code and also has the potential for flask to optimize a bit
Allows for putting OctoPrint assets in other folders
Doesn't make sense to edit it here
OctoPrint has final migrated away from setup.py so this needs to follow suit
No need for that
Needs testing on a system that can actually do it
Give a 404 with a somewhat useful message when the OctoDash index.html is missing
This was referenced Nov 6, 2025
This was referenced Nov 14, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fulfills #4873 so see that for a more detailed breakdown of some pros and cons.
This PR is not intented to be merged but rather will be broken up into several smaller ones.
The list of smaller ones will likely map to this list, but may not be exact.