Skip to content

Fix tf_point_weapon_mimic not using Fire Sound #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix tf_point_weapon_mimic not using Fire Sound #1631

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
525ae1b
Fix tf_point_weapon_mimic not using Fire Sound
WereTech Nov 7, 2025
265968a
forgot the precache
WereTech Nov 7, 2025
bfa7df5
move precache to its own function
WereTech Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions src/game/server/tf/player_vs_environment/tf_point_weapon_mimic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class CTFPointWeaponMimic : public CPointEntity
CTFPointWeaponMimic();
~CTFPointWeaponMimic();
virtual void Spawn();
virtual void Precache();

void InputFireOnce( inputdata_t& inputdata );
void InputFireMultiple( inputdata_t& inputdata );
Expand Down Expand Up @@ -99,13 +100,21 @@ CTFPointWeaponMimic::~CTFPointWeaponMimic()
void CTFPointWeaponMimic::Spawn()
{
BaseClass::Spawn();
Precache();
Copy link
Contributor

@ficool2 ficool2 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Precache is called by the game, you don't call it yourself

Copy link
Author

@WereTech WereTech Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to precache without the explicit call in Spawn, as removing the call will now produce "<sound> not precached" and not play.

ChangeTeam( TF_TEAM_BLUE );
}

void CTFPointWeaponMimic::Precache()
{
if( m_pzsFireSound )
{
PrecacheScriptSound( m_pzsFireSound );
}

if( m_pzsModelOverride )
{
PrecacheModel( m_pzsModelOverride );
}

ChangeTeam( TF_TEAM_BLUE );
}


Expand Down Expand Up @@ -149,6 +158,7 @@ void CTFPointWeaponMimic::Fire()
{
Assert( m_nWeaponType >= 0 && m_nWeaponType < WEAPON_TYPES );

EmitSound( m_pzsFireSound );
switch( m_nWeaponType )
{
case WEAPON_STANDARD_ROCKET:
Expand Down