all games: Add handling for particle systems attached to model panels in particle system query #1644
+156
−113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
GetRandomPointsOnControllingObjectHitBoxandGetControllingObjectHitBoxInfoinCParticleSystemQueryto be able to handle particle systems attached to VGUI model panels.Without this particle systems wouldn't attach to models correctly and
Position on Model Randominitializer wouldn't randomize the particle's position. Can be observed with some Unusual effects and community sparkles in TF's loadout screen and 3D class portraits on the HUD.Before:
particlesystemquery_mdlpanel_handling_before2.webm
After:
particlesystemquery_mdlpanel_handling_after2.webm
Closes ValveSoftware/Source-1-Games#3426, closes ValveSoftware/Source-1-Games#3973