Remove hud_autoaim.cpp from client_base.vpc #1646
Open
+4
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hud_autoaim.cpp uses m_HL2Local which doesn't exist in other inheritors of client_base like tf2 or cstrike, resulting in crashes. This fixes ValveSoftware/Source-1-Games#7112 assuming it gets applied to cstrike aswell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
hud_autoaim.cppusesm_HL2Localwhich doesn't exist in other inheritors of client_base like tf2 or cstrike, resulting in crashes.I'm assuming this was discovered at some point in tf2 since any
m_HL2Localaccess has been removed when compiling for tf2, but this sadly left the issue in cstrike, and a better solution would be to just movehud_autoaim.cppto hl2 VPCs , as it's non-functional in anything else regardless.This fixes ValveSoftware/Source-1-Games#7112 assuming it gets applied to cstrike aswell.