Skip to content

[product] fix dev mode debug text color contrast #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yonava merged 4 commits into from
Oct 18, 2025
Merged

[product] fix dev mode debug text color contrast #535

Yonava merged 4 commits into from
Oct 18, 2025

Conversation

@teykamp
Copy link
Collaborator

@teykamp teykamp commented Sep 8, 2025 •
edited
Loading

makes easier to see on all color themes
fixes #523

@teykamp teykamp added the polish small fixes to make it production-ready label Sep 8, 2025
@teykamp teykamp changed the title [polish] change debug info color from white to black [ui] change debug info color from white to black Sep 8, 2025
@teykamp teykamp added the magic ui UI Components label Sep 8, 2025
@Yonava
Copy link
Owner

Yonava commented Oct 14, 2025 •
edited
Loading

This is not the right fix for this issue 🙅

GText component from products/src/shared/ui/graph-core ✅

wrapping text content in GText automatically applies css that will make the text seamlessly fit into the canvases background 💰💰💰

@Yonava Yonava changed the title [ui] change debug info color from white to black [product] change debug info color from white to black Oct 14, 2025
@Yonava
Copy link
Owner

Yonava commented Oct 14, 2025

because globalGraph.ts is state management for products (which devMode is a part of), its a product fix, not ui fix

@Yonava Yonava self-requested a review October 14, 2025 22:04
Yonava
Yonava reviewed Oct 14, 2025
View reviewed changes
packages/products/src/shared/ui/general/dev/BenchmarkingMetrics.vue
const { fps, slowFrameCount, slowFrameRatio } = useFPS();
</script>

<template>
Copy link
Owner

@Yonava Yonava Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap in GText

@Yonava Yonava changed the title [product] change debug info color from white to black [product] fix dev mode debug text color contrast Oct 14, 2025
@teykamp teykamp requested a review from Yonava October 18, 2025 19:39
@Yonava Yonava merged commit 7fca783 into main Oct 18, 2025
1 check failed
@Yonava Yonava deleted the te/update-debug-mode-text-color branch October 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yonava Yonava Yonava approved these changes

Assignees

No one assigned

Labels

magic ui UI Components polish small fixes to make it production-ready

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ui] Dev mode text should update with canvas theme

3 participants

@teykamp @Yonava